Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

web/admin: disable generated proxy config by default #5372

Merged
merged 1 commit into from Apr 25, 2023

Conversation

BeryJu
Copy link
Member

@BeryJu BeryJu commented Apr 25, 2023

the config generation is often incorrect so let's disable it for now

#5364

Signed-off-by: Jens Langhammer <jens@goauthentik.io>
@codecov
Copy link

codecov bot commented Apr 25, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.10 ⚠️

Comparison is base (58a5c69) 92.73% compared to head (8b275f5) 92.63%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5372      +/-   ##
==========================================
- Coverage   92.73%   92.63%   -0.10%     
==========================================
  Files         506      506              
  Lines       25908    25908              
==========================================
- Hits        24022    23996      -26     
- Misses       1886     1912      +26     
Flag Coverage Δ
e2e 51.97% <ø> (-0.74%) ⬇️
integration 26.27% <ø> (-0.04%) ⬇️
unit 89.53% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 11 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@BeryJu BeryJu merged commit e05f028 into main Apr 25, 2023
55 of 57 checks passed
@BeryJu BeryJu deleted the web/admin/disable-generated-config branch April 25, 2023 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant