Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

providers/scim: correctly handle 404 by re-creating object #5405

Merged
merged 1 commit into from Apr 28, 2023

Conversation

BeryJu
Copy link
Member

@BeryJu BeryJu commented Apr 28, 2023

Signed-off-by: Jens Langhammer <jens@goauthentik.io>
@codecov
Copy link

codecov bot commented Apr 28, 2023

Codecov Report

Patch coverage: 70.00% and project coverage change: -0.01 ⚠️

Comparison is base (0166346) 92.64% compared to head (b8cb66f) 92.62%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5405      +/-   ##
==========================================
- Coverage   92.64%   92.62%   -0.01%     
==========================================
  Files         506      506              
  Lines       25917    25930      +13     
==========================================
+ Hits        24009    24016       +7     
- Misses       1908     1914       +6     
Flag Coverage Δ
e2e 51.87% <25.00%> (-<0.01%) ⬇️
integration 26.28% <25.00%> (-0.05%) ⬇️
unit 89.51% <70.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
authentik/providers/scim/clients/base.py 88.47% <33.34%> (-3.53%) ⬇️
authentik/providers/scim/clients/user.py 77.97% <66.67%> (-2.03%) ⬇️
authentik/providers/scim/clients/group.py 77.09% <80.00%> (-0.69%) ⬇️
authentik/providers/scim/clients/exceptions.py 100.00% <100.00%> (ø)

... and 7 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@BeryJu BeryJu merged commit ecce31e into main Apr 28, 2023
54 of 57 checks passed
@BeryJu BeryJu deleted the providers/scim/improve-404 branch April 28, 2023 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant