Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

blueprints: fix error when imported blueprint is invalid #5414

Merged
merged 1 commit into from Apr 28, 2023

Conversation

BeryJu
Copy link
Member

@BeryJu BeryJu commented Apr 28, 2023

closes #5413

Signed-off-by: Jens Langhammer <jens@goauthentik.io>
@codecov
Copy link

codecov bot commented Apr 28, 2023

Codecov Report

Patch coverage has no change and project coverage change: -36.80 ⚠️

Comparison is base (5830781) 90.37% compared to head (564f532) 53.56%.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #5414       +/-   ##
===========================================
- Coverage   90.37%   53.56%   -36.80%     
===========================================
  Files         506      506               
  Lines       25944    25945        +1     
===========================================
- Hits        23443    13895     -9548     
- Misses       2501    12050     +9549     
Flag Coverage Δ
e2e 51.85% <0.00%> (+3.51%) ⬆️
integration 26.29% <0.00%> (?)
unit ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
authentik/blueprints/api.py 66.67% <0.00%> (-20.43%) ⬇️

... and 381 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@nogweii
Copy link

nogweii commented Apr 28, 2023

Manually applying this fix in my container:

podman cp authentik:/.../api.py api.py
vim api.py
podman cp api.py authentik:/.../api.py
podman exec -it authentik bash
kill -HUP $(pidof /usr/local/bin/python3.11)

And it works! Thanks for the fix. 😄

@nogweii
Copy link

nogweii commented Apr 28, 2023

Hm, this leads to a new error which breaks the admin UI's list of blueprints... which, ah-ha, has already been fixed: 04cc781

@BeryJu BeryJu merged commit af7cc8d into main Apr 28, 2023
52 of 57 checks passed
@BeryJu BeryJu deleted the blueprints/fix-validate-error branch April 28, 2023 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Stacktrace when attempting to save an invalid blueprint to internal storage
2 participants