Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

web/flows: rework redirect logic #5498

Merged
merged 2 commits into from May 5, 2023
Merged

web/flows: rework redirect logic #5498

merged 2 commits into from May 5, 2023

Conversation

BeryJu
Copy link
Member

@BeryJu BeryJu commented May 5, 2023

always use redirect stage, remove special logic from flow executor

show better message when redirect target URL isn't http or https (show notice to close the page)

Details

  • Does this resolve an issue?
    Resolves #

Changes

New Features

  • Adds feature which does x, y, and z.

Breaking Changes

  • Adds breaking change which causes <issue>.

Checklist

  • Local tests pass (ak test authentik/)
  • The code has been formatted (make lint-fix)

If an API change has been made

  • The API schema has been updated (make gen-build)

If changes to the frontend have been made

  • The code has been formatted (make web)
  • The translation files have been updated (make i18n-extract)

If applicable

  • The documentation has been updated
  • The documentation has been formatted (make website)

BeryJu added 2 commits May 5, 2023 22:06
always use redirect stage, remove special logic from flow executor

show better message when redirect target URL isn't http or https (show notice to close the page)

Signed-off-by: Jens Langhammer <jens@goauthentik.io>
Signed-off-by: Jens Langhammer <jens@goauthentik.io>
@github-actions
Copy link
Contributor

github-actions bot commented May 5, 2023

authentik translations instructions

Thanks for your pull request!

authentik translations are handled using Transifex. Please edit translations over there and they'll be included automatically.

@codecov
Copy link

codecov bot commented May 5, 2023

Codecov Report

Patch coverage has no change and project coverage change: -27.35 ⚠️

Comparison is base (b0f5c9b) 53.69% compared to head (b7e4e45) 26.34%.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #5498       +/-   ##
===========================================
- Coverage   53.69%   26.34%   -27.35%     
===========================================
  Files         508      508               
  Lines       26029    26029               
===========================================
- Hits        13974     6855     -7119     
- Misses      12055    19174     +7119     
Flag Coverage Δ
e2e ?
integration 26.34% <ø> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 245 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@BeryJu
Copy link
Member Author

BeryJu commented May 5, 2023

authentik translations instructions

Thanks for your pull request!

authentik translations are handled using Transifex. Please edit translations over there and they'll be included automatically.

@rissson yeah I didn't think of this but the bot is gonna tell us to use transifex when we update the source of truth files, not sure if we can prevent this (maybe have a ci pipeline running that extracts i18n strings and PRs them itself?)

@BeryJu BeryJu merged commit 95a679a into main May 5, 2023
48 of 55 checks passed
@BeryJu BeryJu deleted the web/flows/rework-redirect branch May 5, 2023 20:24
@rissson
Copy link
Member

rissson commented May 5, 2023

Ugh, that's weird, it shouldn't have commented in this case.
https://github.com/goauthentik/authentik/blob/main/.github/workflows/translation-advice.yml#L8 this should make it skip that workflow if translation files changed and source of truth files changed as well. We probably missed something during our test of this :/

@rissson
Copy link
Member

rissson commented May 5, 2023

maybe have a ci pipeline running that extracts i18n strings and PRs them itself

so run make i18n-extract in a CI?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants