Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

web/admin: use radio for client type #5499

Merged
merged 2 commits into from May 5, 2023
Merged

Conversation

BeryJu
Copy link
Member

@BeryJu BeryJu commented May 5, 2023

also fix search select not correctly passing all items in .selected callback

Details

  • Does this resolve an issue?
    Resolves #

Changes

New Features

  • Adds feature which does x, y, and z.

Breaking Changes

  • Adds breaking change which causes <issue>.

Checklist

  • Local tests pass (ak test authentik/)
  • The code has been formatted (make lint-fix)

If an API change has been made

  • The API schema has been updated (make gen-build)

If changes to the frontend have been made

  • The code has been formatted (make web)
  • The translation files have been updated (make i18n-extract)

If applicable

  • The documentation has been updated
  • The documentation has been formatted (make website)

also fix search select not correctly passing all items in .selected callback

Signed-off-by: Jens Langhammer <jens@goauthentik.io>
@github-actions
Copy link
Contributor

github-actions bot commented May 5, 2023

authentik translations instructions

Thanks for your pull request!

authentik translations are handled using Transifex. Please edit translations over there and they'll be included automatically.

Signed-off-by: Jens Langhammer <jens@goauthentik.io>
@netlify
Copy link

netlify bot commented May 5, 2023

Deploy Preview for authentik ready!

Name Link
🔨 Latest commit 56e7361
🔍 Latest deploy log https://app.netlify.com/sites/authentik/deploys/64556756a5fa930008365cfe
😎 Deploy Preview https://deploy-preview-5499--authentik.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@codecov
Copy link

codecov bot commented May 5, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.01 🎉

Comparison is base (95a679a) 91.13% compared to head (56e7361) 91.14%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5499      +/-   ##
==========================================
+ Coverage   91.13%   91.14%   +0.01%     
==========================================
  Files         508      508              
  Lines       26029    26029              
==========================================
+ Hits        23719    23721       +2     
+ Misses       2310     2308       -2     
Flag Coverage Δ
e2e 44.17% <ø> (-<0.01%) ⬇️
integration 26.34% <ø> (+0.02%) ⬆️
unit 89.49% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@BeryJu BeryJu merged commit 36bd4b1 into main May 5, 2023
53 of 58 checks passed
@BeryJu BeryJu deleted the web/admin/improve-oauth2-provider branch May 5, 2023 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant