Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

events: include event user in webhook notification #5524

Merged
merged 2 commits into from May 8, 2023

Conversation

BeryJu
Copy link
Member

@BeryJu BeryJu commented May 8, 2023

Details

The notification currently only has the user the notification was dispatched for, not the user the event was created for

Changes

New Features

  • Adds feature which does x, y, and z.

Breaking Changes

  • Adds breaking change which causes <issue>.

Checklist

  • Local tests pass (ak test authentik/)
  • The code has been formatted (make lint-fix)

If an API change has been made

  • The API schema has been updated (make gen-build)

If changes to the frontend have been made

  • The code has been formatted (make web)
  • The translation files have been updated (make i18n-extract)

If applicable

  • The documentation has been updated
  • The documentation has been formatted (make website)

@codecov
Copy link

codecov bot commented May 8, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.07 ⚠️

Comparison is base (af97669) 92.69% compared to head (6ef6b44) 92.61%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5524      +/-   ##
==========================================
- Coverage   92.69%   92.61%   -0.07%     
==========================================
  Files         508      508              
  Lines       26054    26063       +9     
==========================================
- Hits        24147    24135      -12     
- Misses       1907     1928      +21     
Flag Coverage Δ
e2e 51.78% <18.19%> (-0.80%) ⬇️
integration 26.31% <18.19%> (-0.04%) ⬇️
unit 89.51% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
authentik/events/tests/test_transports.py 100.00% <ø> (ø)
authentik/providers/oauth2/tests/utils.py 100.00% <ø> (ø)
authentik/events/models.py 93.45% <100.00%> (+0.19%) ⬆️
authentik/root/test_runner.py 100.00% <100.00%> (ø)

... and 10 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@netlify
Copy link

netlify bot commented May 8, 2023

Deploy Preview for authentik ready!

Name Link
🔨 Latest commit 9927cd1
🔍 Latest deploy log https://app.netlify.com/sites/authentik/deploys/6458fa5409039600088d0ccc
😎 Deploy Preview https://deploy-preview-5524--authentik.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

BeryJu added 2 commits May 8, 2023 15:33
Signed-off-by: Jens Langhammer <jens@goauthentik.io>
Signed-off-by: Jens Langhammer <jens@goauthentik.io>
@BeryJu BeryJu force-pushed the events/include-event-user branch from 6ef6b44 to 9927cd1 Compare May 8, 2023 13:34
@BeryJu BeryJu merged commit 8215ee1 into main May 8, 2023
22 checks passed
@BeryJu BeryJu deleted the events/include-event-user branch May 8, 2023 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant