Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

providers/SCIM: patch group name #5564

Merged
merged 2 commits into from May 10, 2023
Merged

Conversation

BeryJu
Copy link
Member

@BeryJu BeryJu commented May 10, 2023

Details

#5396

Add patch support for group names when group PUT fails, also fixes ResourceMissing being caught too early and not triggering a re-create

Changes

New Features

  • Adds feature which does x, y, and z.

Breaking Changes

  • Adds breaking change which causes <issue>.

Checklist

  • Local tests pass (ak test authentik/)
  • The code has been formatted (make lint-fix)

If an API change has been made

  • The API schema has been updated (make gen-build)

If changes to the frontend have been made

  • The code has been formatted (make web)
  • The translation files have been updated (make i18n-extract)

If applicable

  • The documentation has been updated
  • The documentation has been formatted (make website)

Signed-off-by: Jens Langhammer <jens@goauthentik.io>
@BeryJu BeryJu force-pushed the providers/scim/patch-group-name branch from f31489d to 3c090de Compare May 10, 2023 09:12
Signed-off-by: Jens Langhammer <jens@goauthentik.io>
@BeryJu BeryJu force-pushed the providers/scim/patch-group-name branch from 3c090de to c0944a6 Compare May 10, 2023 09:17
@codecov
Copy link

codecov bot commented May 10, 2023

Codecov Report

Patch coverage: 57.15% and project coverage change: -0.13 ⚠️

Comparison is base (639a5c4) 92.74% compared to head (c0944a6) 92.60%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5564      +/-   ##
==========================================
- Coverage   92.74%   92.60%   -0.13%     
==========================================
  Files         546      546              
  Lines       26140    26143       +3     
==========================================
- Hits        24240    24207      -33     
- Misses       1900     1936      +36     
Flag Coverage Δ
e2e 51.82% <14.29%> (-0.77%) ⬇️
integration 26.33% <14.29%> (-0.06%) ⬇️
unit 89.54% <57.15%> (-<0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
authentik/providers/scim/clients/group.py 68.97% <57.15%> (-0.94%) ⬇️

... and 13 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@BeryJu BeryJu merged commit 1c04dc0 into main May 10, 2023
54 of 57 checks passed
@BeryJu BeryJu deleted the providers/scim/patch-group-name branch May 10, 2023 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant