Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sources/ldap: add support for cert based auth #5850

Merged
merged 14 commits into from Jun 12, 2023

Conversation

ChandonPierre
Copy link
Contributor

@ChandonPierre ChandonPierre commented Jun 4, 2023

Details

Changes

New Features

  • Adds support to authenticate against an LDAP source using certificate based authentication, like Google Secure LDAP

image

Breaking Changes

  • No known breaking change

Checklist

  • Local tests pass (ak test authentik/)
  • The code has been formatted (make lint-fix)

If an API change has been made

  • The API schema has been updated (make gen-build)

If changes to the frontend have been made

  • The code has been formatted (make web)
  • The translation files have been updated (make i18n-extract)

If applicable

  • The documentation has been updated
  • The documentation has been formatted (make website)

@ChandonPierre ChandonPierre requested a review from a team as a code owner June 4, 2023 19:46
@netlify
Copy link

netlify bot commented Jun 6, 2023

Deploy Preview for authentik ready!

Name Link
🔨 Latest commit 9108873
🔍 Latest deploy log https://app.netlify.com/sites/authentik/deploys/6483715b8de2fe0008d70931
😎 Deploy Preview https://deploy-preview-5850--authentik.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

authentik/sources/ldap/models.py Outdated Show resolved Hide resolved
authentik/sources/ldap/models.py Outdated Show resolved Hide resolved
authentik/sources/ldap/models.py Outdated Show resolved Hide resolved
blueprints/system/sources-ldap.yaml Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Jun 6, 2023

Codecov Report

Patch coverage: 29.63% and project coverage change: -0.22 ⚠️

Comparison is base (1ae3609) 92.62% compared to head (f9d2394) 92.40%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5850      +/-   ##
==========================================
- Coverage   92.62%   92.40%   -0.22%     
==========================================
  Files         550      550              
  Lines       26380    26403      +23     
==========================================
- Hits        24433    24396      -37     
- Misses       1947     2007      +60     
Flag Coverage Δ
e2e 51.00% <29.63%> (-0.77%) ⬇️
integration 26.43% <18.52%> (-<0.01%) ⬇️
unit 89.40% <29.63%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
authentik/sources/ldap/models.py 55.86% <20.84%> (-28.75%) ⬇️
authentik/sources/ldap/api.py 75.31% <100.00%> (+0.95%) ⬆️

... and 10 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@netlify
Copy link

netlify bot commented Jun 9, 2023

Deploy Preview for authentik-storybook ready!

Name Link
🔨 Latest commit f9d2394
🔍 Latest deploy log https://app.netlify.com/sites/authentik-storybook/deploys/64870c031954790008fa06e6
😎 Deploy Preview https://deploy-preview-5850--authentik-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

we set $TMPDIR in the dockerfile

Signed-off-by: Jens Langhammer <jens@goauthentik.io>
Signed-off-by: Jens Langhammer <jens@goauthentik.io>
Signed-off-by: Jens Langhammer <jens@goauthentik.io>
Signed-off-by: Jens Langhammer <jens@goauthentik.io>
Signed-off-by: Jens L. <jens@goauthentik.io>
@BeryJu BeryJu merged commit 029395d into goauthentik:main Jun 12, 2023
60 of 63 checks passed
kensternberg-authentik added a commit that referenced this pull request Jun 12, 2023
* main: (23 commits)
  web: bump API Client version (#5935)
  sources/ldap: add support for cert based auth (#5850)
  ci: replace status with state for auto-deployment
  ci: don't write CI status to file
  ci: add workflow to automatically update next branch (#5921)
  providers/ldap: fix Outpost provider listing excluding backchannel providers (#5933)
  root: revert to use secret_key for JWT signing (#5934)
  sources/ldap: fix duplicate bind when authenticating user directly to… (#5927)
  web: bump core-js from 3.30.2 to 3.31.0 in /web (#5928)
  core: bump pytest from 7.3.1 to 7.3.2 (#5929)
  web: bump @rollup/plugin-commonjs from 25.0.0 to 25.0.1 in /web (#5931)
  web: bump @formatjs/intl-listformat from 7.3.0 to 7.4.0 in /web (#5932)
  core: bump github.com/go-ldap/ldap/v3 from 3.4.4 to 3.4.5 (#5930)
  website/integrations: Fix header in dokuwiki instructions (#5926)
  providers/oauth2: launch url: if URL parsing fails, return no launch URL (#5918)
  web: bump @babel/core from 7.22.1 to 7.22.5 in /web (#5909)
  web: bump @babel/plugin-proposal-decorators from 7.22.3 to 7.22.5 in /web (#5910)
  web: bump @babel/preset-typescript from 7.21.5 to 7.22.5 in /web (#5912)
  web: bump @babel/preset-env from 7.22.4 to 7.22.5 in /web (#5915)
  core: bump requests-mock from 1.10.0 to 1.11.0 (#5911)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to authenticate users via Google Secure LDAP
2 participants