Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sources/ldap: include UnwillingToPerformError as possible exception #6031

Merged
merged 1 commit into from Jun 21, 2023

Conversation

smusali
Copy link
Contributor

@smusali smusali commented Jun 21, 2023

Details

Changes

New Features

  • Adds feature which does x, y, and z.

Breaking Changes

  • Adds breaking change which causes <issue>.

Checklist

  • Local tests pass (ak test authentik/)
  • The code has been formatted (make lint-fix)

If an API change has been made

  • The API schema has been updated (make gen-build)

If changes to the frontend have been made

  • The code has been formatted (make web)
  • The translation files have been updated (make i18n-extract)

If applicable

  • The documentation has been updated
  • The documentation has been formatted (make website)

@smusali smusali added enhancement New feature or request python Pull requests that update Python code from_authentik Issues created through a link from authentik (https://goauthentik.io/docs/events/#system_exception) needs_documentation Questions/Issues that require additional documentation labels Jun 21, 2023
@smusali smusali self-assigned this Jun 21, 2023
@netlify
Copy link

netlify bot commented Jun 21, 2023

Deploy Preview for authentik-storybook canceled.

Name Link
🔨 Latest commit c807679
🔍 Latest deploy log https://app.netlify.com/sites/authentik-storybook/deploys/6493232b9d033300081c0326

@BeryJu BeryJu removed the from_authentik Issues created through a link from authentik (https://goauthentik.io/docs/events/#system_exception) label Jun 21, 2023
@codecov
Copy link

codecov bot commented Jun 21, 2023

Codecov Report

Patch coverage: 50.00% and project coverage change: -1.30 ⚠️

Comparison is base (17fbba2) 92.62% compared to head (d84705a) 91.31%.

❗ Current head d84705a differs from pull request most recent head c807679. Consider uploading reports for the commit c807679 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6031      +/-   ##
==========================================
- Coverage   92.62%   91.31%   -1.30%     
==========================================
  Files         550      550              
  Lines       26486    26486              
==========================================
- Hits        24529    24183     -346     
- Misses       1957     2303     +346     
Flag Coverage Δ
e2e 46.10% <50.00%> (-5.67%) ⬇️
integration 26.39% <50.00%> (ø)
unit 89.47% <50.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
authentik/sources/ldap/password.py 67.93% <50.00%> (ø)

... and 43 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@github-actions
Copy link
Contributor

github-actions bot commented Jun 21, 2023

authentik PR Installation instructions

Instructions for docker-compose

Add the following block to your .env file:

AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-smusali-5693-1687365126-c807679
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s

For arm64, use these values:

AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-smusali-5693-1687365126-c807679-arm64
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s

Afterwards, run the upgrade commands from the latest release notes.

Instructions for Kubernetes

Add the following block to your values.yml file:

authentik:
    outposts:
        container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
image:
    repository: ghcr.io/goauthentik/dev-server
    tag: gh-smusali-5693-1687365126-c807679

For arm64, use these values:

authentik:
    outposts:
        container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
image:
    repository: ghcr.io/goauthentik/dev-server
    tag: gh-smusali-5693-1687365126-c807679-arm64

Afterwards, run the upgrade commands from the latest release notes.

@smusali smusali force-pushed the smusali/5693 branch 3 times, most recently from 1a75cb6 to a6730ed Compare June 21, 2023 15:52
@smusali smusali marked this pull request as ready for review June 21, 2023 16:20
@smusali smusali requested a review from a team as a code owner June 21, 2023 16:20
@BeryJu BeryJu changed the title feat: include UnwillingToPerformError as possible exception sources/ldap: include UnwillingToPerformError as possible exception Jun 21, 2023
@smusali smusali merged commit b1de0b7 into main Jun 21, 2023
61 of 62 checks passed
@smusali smusali deleted the smusali/5693 branch June 21, 2023 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request needs_documentation Questions/Issues that require additional documentation python Pull requests that update Python code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add UnwillingToPerformError to ldap/password.py:95
2 participants