Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

web/admin: fix admin overview layout #6220

Merged
merged 2 commits into from Jul 11, 2023
Merged

Conversation

BeryJu
Copy link
Member

@BeryJu BeryJu commented Jul 11, 2023

Details

The layout is a bit broken currently on devices that are around ipad sized. This PR fixes most of those issues

Changes

New Features

  • Adds feature which does x, y, and z.

Breaking Changes

  • Adds breaking change which causes <issue>.

Checklist

  • Local tests pass (ak test authentik/)
  • The code has been formatted (make lint-fix)

If an API change has been made

  • The API schema has been updated (make gen-build)

If changes to the frontend have been made

  • The code has been formatted (make web)
  • The translation files have been updated (make i18n-extract)

If applicable

  • The documentation has been updated
  • The documentation has been formatted (make website)

Signed-off-by: Jens Langhammer <jens@goauthentik.io>
@BeryJu BeryJu requested a review from a team as a code owner July 11, 2023 18:33
@BeryJu BeryJu requested review from tanberry and removed request for a team July 11, 2023 18:33
@netlify
Copy link

netlify bot commented Jul 11, 2023

Deploy Preview for authentik-storybook ready!

Name Link
🔨 Latest commit e68ab10
🔍 Latest deploy log https://app.netlify.com/sites/authentik-storybook/deploys/64ada0b74486e00008a480cc
😎 Deploy Preview https://deploy-preview-6220--authentik-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Signed-off-by: Jens Langhammer <jens@goauthentik.io>
@github-actions
Copy link
Contributor

authentik translations instructions

Thanks for your pull request!

authentik translations are handled using Transifex. Please edit translations over there and they'll be included automatically.

@codecov
Copy link

codecov bot commented Jul 11, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.03 🎉

Comparison is base (6345c7f) 92.68% compared to head (e68ab10) 92.70%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6220      +/-   ##
==========================================
+ Coverage   92.68%   92.70%   +0.03%     
==========================================
  Files         551      551              
  Lines       26593    26593              
==========================================
+ Hits        24645    24651       +6     
+ Misses       1948     1942       -6     
Flag Coverage Δ
e2e 51.51% <ø> (+0.04%) ⬆️
integration 26.37% <ø> (ø)
unit 89.60% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 4 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@BeryJu BeryJu merged commit f4e94bf into main Jul 11, 2023
62 of 63 checks passed
@BeryJu BeryJu deleted the web/admin/fix-overview-layout branch July 11, 2023 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant