Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

providers/oauth2: fix grant_type password raising an exception #6333

Merged
merged 1 commit into from Jul 21, 2023

Conversation

BeryJu
Copy link
Member

@BeryJu BeryJu commented Jul 21, 2023

Details

#6139

doesn't fully solve the issue as we're still technically not complaint with our client_credentials grant implementation

Changes

New Features

  • Adds feature which does x, y, and z.

Breaking Changes

  • Adds breaking change which causes <issue>.

Checklist

  • Local tests pass (ak test authentik/)
  • The code has been formatted (make lint-fix)

If an API change has been made

  • The API schema has been updated (make gen-build)

If changes to the frontend have been made

  • The code has been formatted (make web)
  • The translation files have been updated (make i18n-extract)

If applicable

  • The documentation has been updated
  • The documentation has been formatted (make website)

@BeryJu BeryJu requested a review from a team as a code owner July 21, 2023 23:04
@BeryJu BeryJu requested review from tanberry and removed request for a team July 21, 2023 23:04
@netlify
Copy link

netlify bot commented Jul 21, 2023

Deploy Preview for authentik-storybook canceled.

Name Link
🔨 Latest commit 09bca51
🔍 Latest deploy log https://app.netlify.com/sites/authentik-storybook/deploys/64bb0f376c533c000896e396

Signed-off-by: Jens Langhammer <jens@goauthentik.io>
@BeryJu BeryJu force-pushed the providers/oauth2/fix-grant-type-password branch from 86cfcf4 to 09bca51 Compare July 21, 2023 23:05
@codecov
Copy link

codecov bot commented Jul 21, 2023

Codecov Report

Patch coverage: 91.67% and project coverage change: +0.10 🎉

Comparison is base (e0564b3) 92.37% compared to head (09bca51) 92.47%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6333      +/-   ##
==========================================
+ Coverage   92.37%   92.47%   +0.10%     
==========================================
  Files         560      560              
  Lines       26930    26939       +9     
==========================================
+ Hits        24875    24908      +33     
+ Misses       2055     2031      -24     
Flag Coverage Δ
e2e 51.65% <0.00%> (+0.70%) ⬆️
integration 26.43% <0.00%> (-<0.01%) ⬇️
unit 89.38% <91.67%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
authentik/providers/oauth2/views/token.py 87.14% <66.67%> (ø)
authentik/providers/oauth2/tests/test_token_cc.py 100.00% <100.00%> (ø)

... and 6 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@github-actions
Copy link
Contributor

authentik PR Installation instructions

Instructions for docker-compose

Add the following block to your .env file:

AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-providers-oauth2-fix-grant-type-password-1689981378-09bca51
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s

For arm64, use these values:

AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-providers-oauth2-fix-grant-type-password-1689981378-09bca51-arm64
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s

Afterwards, run the upgrade commands from the latest release notes.

Instructions for Kubernetes

Add the following block to your values.yml file:

authentik:
    outposts:
        container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
image:
    repository: ghcr.io/goauthentik/dev-server
    tag: gh-providers-oauth2-fix-grant-type-password-1689981378-09bca51

For arm64, use these values:

authentik:
    outposts:
        container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
image:
    repository: ghcr.io/goauthentik/dev-server
    tag: gh-providers-oauth2-fix-grant-type-password-1689981378-09bca51-arm64

Afterwards, run the upgrade commands from the latest release notes.

@BeryJu BeryJu merged commit a728dad into main Jul 21, 2023
61 of 62 checks passed
@BeryJu BeryJu deleted the providers/oauth2/fix-grant-type-password branch July 21, 2023 23:36
kensternberg-authentik added a commit that referenced this pull request Jul 24, 2023
* main:
  web/admin: hide pagination when no data is loaded yet (#6353)
  web/admin: adjust style of page header (#6355)
  root: set csrf cookie's secure flag same as session (#6350)
  outposts: Fix infinite self-recursion in traefik reconciler. (#6336)
  outposts: fix patch processing (#6338)
  web: bump API Client version (#6351)
  Updates for file web/xliff/en.xlf in zh_CN on branch main (#6340)
  Updates for file web/xliff/en.xlf in zh-Hans on branch main (#6341)
  enterprise: fix license check not using DER as spec specifies (#6348)
  core: bump goauthentik.io/api/v3 from 3.2023061.3 to 3.2023061.4 (#6342)
  core: bump drf-spectacular from 0.26.3 to 0.26.4 (#6343)
  core: bump ruff from 0.0.278 to 0.0.280 (#6344)
  website: bump postcss from 8.4.26 to 8.4.27 in /website (#6345)
  web: bump @esbuild/linux-arm64 from 0.18.15 to 0.18.16 in /web (#6347)
  web: bump @esbuild/darwin-arm64 from 0.18.15 to 0.18.16 in /web (#6346)
  outposts: support json patch for Kubernetes (#6319)
  providers/oauth2: fix grant_type password raising an exception (#6333)
  web: bump API Client version (#6331)
  enterprise: cleanup v2 (#6330)
  web: bump prettier from 2.8.8 to 3.0.0 in /web (#6329)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant