Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

providers/proxy: only intercept auth header when a value is set #6488

Merged
merged 1 commit into from Aug 5, 2023

Conversation

BeryJu
Copy link
Member

@BeryJu BeryJu commented Aug 5, 2023

Details

change the Authorization header setting logic to take into consideration if the username and password are empty from the user attributes are empty strings, and if so not change anything

closes #5846


Checklist

  • Local tests pass (ak test authentik/)
  • The code has been formatted (make lint-fix)

If an API change has been made

  • The API schema has been updated (make gen-build)

If changes to the frontend have been made

  • The code has been formatted (make web)
  • The translation files have been updated (make i18n-extract)

If applicable

  • The documentation has been updated
  • The documentation has been formatted (make website)

Signed-off-by: Jens Langhammer <jens@goauthentik.io>
@BeryJu BeryJu requested a review from a team as a code owner August 5, 2023 23:02
@BeryJu BeryJu requested review from kensternberg-authentik and removed request for a team August 5, 2023 23:02
@netlify
Copy link

netlify bot commented Aug 5, 2023

Deploy Preview for authentik-storybook canceled.

Name Link
🔨 Latest commit 03338a6
🔍 Latest deploy log https://app.netlify.com/sites/authentik-storybook/deploys/64ced51b93168c0008041c2a

@codecov
Copy link

codecov bot commented Aug 5, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.01% 🎉

Comparison is base (7124a62) 92.46% compared to head (03338a6) 92.46%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6488      +/-   ##
==========================================
+ Coverage   92.46%   92.46%   +0.01%     
==========================================
  Files         561      561              
  Lines       27081    27081              
==========================================
+ Hits        25037    25038       +1     
+ Misses       2044     2043       -1     
Flag Coverage Δ
e2e 51.58% <ø> (-0.01%) ⬇️
integration 26.57% <ø> (ø)
unit 89.27% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@BeryJu BeryJu merged commit f6b144a into main Aug 5, 2023
62 of 63 checks passed
@BeryJu BeryJu deleted the providers/proxy/only-intercept-auth-when-required branch August 5, 2023 23:18
@github-actions
Copy link
Contributor

github-actions bot commented Aug 5, 2023

authentik PR Installation instructions

Instructions for docker-compose

Add the following block to your .env file:

AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-providers-proxy-only-intercept-auth-when-required-1691277371-03338a6
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s

For arm64, use these values:

AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-providers-proxy-only-intercept-auth-when-required-1691277371-03338a6-arm64
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s

Afterwards, run the upgrade commands from the latest release notes.

Instructions for Kubernetes

Add the following block to your values.yml file:

authentik:
    outposts:
        container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
image:
    repository: ghcr.io/goauthentik/dev-server
    tag: gh-providers-proxy-only-intercept-auth-when-required-1691277371-03338a6

For arm64, use these values:

authentik:
    outposts:
        container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
image:
    repository: ghcr.io/goauthentik/dev-server
    tag: gh-providers-proxy-only-intercept-auth-when-required-1691277371-03338a6-arm64

Afterwards, run the upgrade commands from the latest release notes.

BeryJu added a commit that referenced this pull request Aug 7, 2023
Signed-off-by: Jens Langhammer <jens@goauthentik.io>
kensternberg-authentik added a commit that referenced this pull request Aug 7, 2023
* main:
  web/flows: fix identification stage band color (#6489)
  providers/proxy: only intercept auth header when a value is set (#6488)
  web: bump @goauthentik/api from 2023.6.1-1691242648 to 2023.6.1-1691266058 in /web (#6486)
  providers/proxy: set outpost session cookie to httponly and secure wh… (#6482)
  web: bump @esbuild/linux-arm64 from 0.18.17 to 0.18.18 in /web (#6483)
  web/admin: fix user sorting by active field (#6485)
  web: bump @esbuild/darwin-arm64 from 0.18.17 to 0.18.18 in /web (#6484)
  web: bump storybook (#6481)
  web: bump the sentry group in /web with 2 updates (#6480)
  web: bump API Client version (#6479)
  api: optimise pagination in API schema (#6478)
  website/dev-docs: tweaks to template (#6474)
  website: bump react-tooltip from 5.19.0 to 5.20.0 in /website (#6471)
  website: bump prettier from 3.0.0 to 3.0.1 in /website (#6472)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Authentication Header Stripped in Requests via Unauthenticated Paths
1 participant