Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

web/admin: make version clickable for stable releases #6626

Merged
merged 1 commit into from Aug 25, 2023

Conversation

BeryJu
Copy link
Member

@BeryJu BeryJu commented Aug 25, 2023

Details

What we just talked about

Also remove the general link to our releases as it's not really useful

Checklist

  • Local tests pass (ak test authentik/)
  • The code has been formatted (make lint-fix)

If an API change has been made

  • The API schema has been updated (make gen-build)

If changes to the frontend have been made

  • The code has been formatted (make web)
  • The translation files have been updated (make i18n-extract)

If applicable

  • The documentation has been updated
  • The documentation has been formatted (make website)

Signed-off-by: Jens Langhammer <jens@goauthentik.io>
@BeryJu BeryJu requested a review from tanberry August 25, 2023 17:08
@BeryJu BeryJu requested a review from a team as a code owner August 25, 2023 17:08
@netlify
Copy link

netlify bot commented Aug 25, 2023

Deploy Preview for authentik-storybook ready!

Name Link
🔨 Latest commit 4a3c8c8
🔍 Latest deploy log https://app.netlify.com/sites/authentik-storybook/deploys/64e8dff6438b260008994a8d
😎 Deploy Preview https://deploy-preview-6626--authentik-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codecov
Copy link

codecov bot commented Aug 25, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.02% ⚠️

Comparison is base (b08ca98) 92.49% compared to head (4a3c8c8) 92.46%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6626      +/-   ##
==========================================
- Coverage   92.49%   92.46%   -0.02%     
==========================================
  Files         561      561              
  Lines       27093    27093              
==========================================
- Hits        25056    25049       -7     
- Misses       2037     2044       +7     
Flag Coverage Δ
e2e 51.61% <ø> (-0.01%) ⬇️
integration 26.57% <ø> (ø)
unit 89.28% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@BeryJu BeryJu merged commit 72dd758 into main Aug 25, 2023
61 of 63 checks passed
@BeryJu BeryJu deleted the web/admin/make-version-clickable branch August 25, 2023 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant