Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

root: expand exception logging #6690

Merged
merged 1 commit into from Aug 31, 2023
Merged

root: expand exception logging #6690

merged 1 commit into from Aug 31, 2023

Conversation

BeryJu
Copy link
Member

@BeryJu BeryJu commented Aug 30, 2023

Details

Unhandled exceptions are currently logged like this, which doesn't really provide much info to debug

{
    "event": "Internal Server Error: /api/v3/flows/executor/default-authentication-flow/",
    "exc_info": ["<class 'TypeError'>", "TypeError(\"'NoneType' object is not subscriptable\")", "<traceback object at 0x7f1a867c6b00>"],
    "level": "error",
    "logger": "django.request",
    "timestamp": 1692706012.3281372
}

Checklist

  • Local tests pass (ak test authentik/)
  • The code has been formatted (make lint-fix)

If an API change has been made

  • The API schema has been updated (make gen-build)

If changes to the frontend have been made

  • The code has been formatted (make web)
  • The translation files have been updated (make i18n-extract)

If applicable

  • The documentation has been updated
  • The documentation has been formatted (make website)

Signed-off-by: Jens Langhammer <jens@goauthentik.io>
@BeryJu BeryJu requested a review from a team as a code owner August 30, 2023 11:47
@BeryJu BeryJu requested review from kensternberg-authentik and removed request for a team August 30, 2023 11:47
@netlify
Copy link

netlify bot commented Aug 30, 2023

Deploy Preview for authentik-storybook canceled.

Name Link
🔨 Latest commit 28e83db
🔍 Latest deploy log https://app.netlify.com/sites/authentik-storybook/deploys/64ef2c57837fdf000827e727

@codecov
Copy link

codecov bot commented Aug 30, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.02% ⚠️

Comparison is base (bfd0fb6) 92.49% compared to head (28e83db) 92.47%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6690      +/-   ##
==========================================
- Coverage   92.49%   92.47%   -0.02%     
==========================================
  Files         561      561              
  Lines       27148    27148              
==========================================
- Hits        25109    25102       -7     
- Misses       2039     2046       +7     
Flag Coverage Δ
e2e 51.50% <ø> (-0.04%) ⬇️
integration 26.52% <ø> (ø)
unit 89.30% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
authentik/root/settings.py 88.64% <ø> (ø)

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions
Copy link
Contributor

authentik PR Installation instructions

Instructions for docker-compose

Add the following block to your .env file:

AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-root-expand-error-logging-1693396819-28e83db
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s

For arm64, use these values:

AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-root-expand-error-logging-1693396819-28e83db-arm64
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s

Afterwards, run the upgrade commands from the latest release notes.

Instructions for Kubernetes

Add the following block to your values.yml file:

authentik:
    outposts:
        container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
image:
    repository: ghcr.io/goauthentik/dev-server
    tag: gh-root-expand-error-logging-1693396819-28e83db

For arm64, use these values:

authentik:
    outposts:
        container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
image:
    repository: ghcr.io/goauthentik/dev-server
    tag: gh-root-expand-error-logging-1693396819-28e83db-arm64

Afterwards, run the upgrade commands from the latest release notes.

@BeryJu BeryJu merged commit 1c1c1cf into main Aug 31, 2023
63 checks passed
@BeryJu BeryJu deleted the root/expand-error-logging branch August 31, 2023 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant