Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stages/authenticator: vendor otp #6741

Merged
merged 18 commits into from Sep 4, 2023
Merged

Conversation

BeryJu
Copy link
Member

@BeryJu BeryJu commented Sep 3, 2023

Details

As we're in the process of implementing mobile as an authenticator device, "vendoring" makes a lot more sense for this as it allows much deeper customisation

Also we get to strip away a lot of the code we don't need such as Django admin, forms, middleware, etc


Checklist

  • Local tests pass (ak test authentik/)
  • The code has been formatted (make lint-fix)

If an API change has been made

  • The API schema has been updated (make gen-build)

If changes to the frontend have been made

  • The code has been formatted (make web)
  • The translation files have been updated (make i18n-extract)

If applicable

  • The documentation has been updated
  • The documentation has been formatted (make website)

@BeryJu BeryJu requested a review from a team as a code owner September 3, 2023 01:11
@BeryJu BeryJu requested review from kensternberg-authentik and removed request for a team September 3, 2023 01:11
@netlify
Copy link

netlify bot commented Sep 3, 2023

Deploy Preview for authentik-storybook canceled.

Name Link
🔨 Latest commit 59020a0
🔍 Latest deploy log https://app.netlify.com/sites/authentik-storybook/deploys/64f57e24861d5c00087c4d30

@BeryJu BeryJu marked this pull request as draft September 3, 2023 01:12
@codecov
Copy link

codecov bot commented Sep 3, 2023

Codecov Report

Patch coverage: 96.62% and project coverage change: +0.21% 🎉

Comparison is base (3f12c7c) 92.50% compared to head (59020a0) 92.70%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6741      +/-   ##
==========================================
+ Coverage   92.50%   92.70%   +0.21%     
==========================================
  Files         562      565       +3     
  Lines       27209    27757     +548     
==========================================
+ Hits        25166    25730     +564     
+ Misses       2043     2027      -16     
Flag Coverage Δ
e2e 51.25% <39.94%> (-0.24%) ⬇️
integration 26.46% <23.36%> (-0.08%) ⬇️
unit 89.59% <96.62%> (+0.27%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
authentik/root/settings.py 88.53% <ø> (ø)
authentik/root/test_runner.py 100.00% <ø> (ø)
authentik/stages/authenticator_totp/settings.py 100.00% <ø> (ø)
authentik/enterprise/policy.py 40.91% <12.50%> (+40.91%) ⬆️
authentik/stages/authenticator/models.py 93.82% <93.82%> (ø)
authentik/stages/authenticator/util.py 95.84% <95.84%> (ø)
authentik/stages/authenticator_totp/models.py 97.15% <96.11%> (-2.85%) ⬇️
authentik/stages/authenticator_static/models.py 98.25% <96.78%> (-1.75%) ⬇️
authentik/stages/authenticator/tests.py 98.39% <98.39%> (ø)
authentik/core/api/devices.py 78.38% <100.00%> (ø)
... and 18 more

... and 4 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@BeryJu BeryJu force-pushed the stages/authenticator/vendor-otp branch 3 times, most recently from 20c31ae to 6dab842 Compare September 3, 2023 20:32
@github-actions
Copy link
Contributor

github-actions bot commented Sep 3, 2023

authentik PR Installation instructions

Instructions for docker-compose

Add the following block to your .env file:

AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-stages-authenticator-vendor-otp-1693811188-59020a0
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s

For arm64, use these values:

AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-stages-authenticator-vendor-otp-1693811188-59020a0-arm64
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s

Afterwards, run the upgrade commands from the latest release notes.

Instructions for Kubernetes

Add the following block to your values.yml file:

authentik:
    outposts:
        container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
image:
    repository: ghcr.io/goauthentik/dev-server
    tag: gh-stages-authenticator-vendor-otp-1693811188-59020a0

For arm64, use these values:

authentik:
    outposts:
        container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
image:
    repository: ghcr.io/goauthentik/dev-server
    tag: gh-stages-authenticator-vendor-otp-1693811188-59020a0-arm64

Afterwards, run the upgrade commands from the latest release notes.

@BeryJu BeryJu marked this pull request as ready for review September 3, 2023 21:33
Signed-off-by: Jens Langhammer <jens@goauthentik.io>
Signed-off-by: Jens Langhammer <jens@goauthentik.io>
Signed-off-by: Jens Langhammer <jens@goauthentik.io>
Signed-off-by: Jens Langhammer <jens@goauthentik.io>
Signed-off-by: Jens Langhammer <jens@goauthentik.io>
Signed-off-by: Jens Langhammer <jens@goauthentik.io>
Signed-off-by: Jens Langhammer <jens@goauthentik.io>
Signed-off-by: Jens Langhammer <jens@goauthentik.io>
Signed-off-by: Jens Langhammer <jens@goauthentik.io>
Signed-off-by: Jens Langhammer <jens@goauthentik.io>
Signed-off-by: Jens Langhammer <jens@goauthentik.io>
Signed-off-by: Jens Langhammer <jens@goauthentik.io>
Signed-off-by: Jens Langhammer <jens@goauthentik.io>
Signed-off-by: Jens Langhammer <jens@goauthentik.io>
Signed-off-by: Jens Langhammer <jens@goauthentik.io>
Signed-off-by: Jens Langhammer <jens@goauthentik.io>
Signed-off-by: Jens Langhammer <jens@goauthentik.io>
Signed-off-by: Jens Langhammer <jens@goauthentik.io>
@BeryJu BeryJu force-pushed the stages/authenticator/vendor-otp branch from 6dab842 to 59020a0 Compare September 4, 2023 06:50
@BeryJu BeryJu merged commit 6612f72 into main Sep 4, 2023
61 of 64 checks passed
@BeryJu BeryJu deleted the stages/authenticator/vendor-otp branch September 4, 2023 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant