Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

root: lock node to 20.5 #6776

Merged
merged 2 commits into from Sep 6, 2023
Merged

root: lock node to 20.5 #6776

merged 2 commits into from Sep 6, 2023

Conversation

BeryJu
Copy link
Member

@BeryJu BeryJu commented Sep 6, 2023

Details

Node 20.6 broke some things


Checklist

  • Local tests pass (ak test authentik/)
  • The code has been formatted (make lint-fix)

If an API change has been made

  • The API schema has been updated (make gen-build)

If changes to the frontend have been made

  • The code has been formatted (make web)
  • The translation files have been updated (make i18n-extract)

If applicable

  • The documentation has been updated
  • The documentation has been formatted (make website)

there are apparently some breaking issues in 20.6 with babel babel/babel#15927

Signed-off-by: Jens Langhammer <jens@goauthentik.io>
Signed-off-by: Jens Langhammer <jens@goauthentik.io>
@BeryJu BeryJu requested a review from a team as a code owner September 6, 2023 10:12
@BeryJu BeryJu requested review from smilelyj and removed request for a team September 6, 2023 10:12
@netlify
Copy link

netlify bot commented Sep 6, 2023

Deploy Preview for authentik-storybook canceled.

Name Link
🔨 Latest commit 47cc1f6
🔍 Latest deploy log https://app.netlify.com/sites/authentik-storybook/deploys/64f8507d36e5b4000826953e

@codecov
Copy link

codecov bot commented Sep 6, 2023

Codecov Report

Patch coverage has no change and project coverage change: +22.02% 🎉

Comparison is base (912f8da) 26.43% compared to head (47cc1f6) 48.44%.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #6776       +/-   ##
===========================================
+ Coverage   26.43%   48.44%   +22.02%     
===========================================
  Files         565      565               
  Lines       27769    27769               
===========================================
+ Hits         7338    13450     +6112     
+ Misses      20431    14319     -6112     
Flag Coverage Δ
e2e 46.68% <ø> (?)
integration 26.43% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 261 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@BeryJu BeryJu merged commit 2c8f8b9 into main Sep 6, 2023
60 checks passed
@BeryJu BeryJu deleted the root/lock-node-20.5 branch September 6, 2023 10:22
BeryJu added a commit that referenced this pull request Sep 6, 2023
* root: lock node to 20.5

there are apparently some breaking issues in 20.6 with babel babel/babel#15927

Signed-off-by: Jens Langhammer <jens@goauthentik.io>

* use same version of setup-node everywhere

Signed-off-by: Jens Langhammer <jens@goauthentik.io>

---------

Signed-off-by: Jens Langhammer <jens@goauthentik.io>
# Conflicts:
#	.github/workflows/ci-web.yml
#	.github/workflows/ci-website.yml
kensternberg-authentik added a commit that referenced this pull request Sep 12, 2023
* main: (28 commits)
  root: add option to disable beat when running worker (#6849)
  core: bump ruff from 0.0.287 to 0.0.288 (#6858)
  core: bump goauthentik.io/api/v3 from 3.2023082.6 to 3.2023083.1 (#6859)
  root: fix gunicorn not starting
  providers/saml: set WantAuthnRequestsSigned in metadata (#6851)
  root: fix dumb-init
  web: bump the eslint group in /web with 1 update (#6846)
  web: bump @typescript-eslint/parser from 6.6.0 to 6.7.0 in /web (#6847)
  web: bump API Client version (#6850)
  release: 2023.8.3
  website/docs: prepare 2023.8.3 release notes (#6843)
  core: remove celery's duplicate max_tasks_per_child (#6840)
  providers/scim: check that a provider exists before starting scim task (#6841)
  web/admin: fix flow-search not being able to unset (#6838)
  sources/ldap: dont prefetch useless items (#6812)
  sources/ldap: fix task timeout for ldap_sync_all and ldap_sync_single (#6809)
  root: lock node to 20.5 (#6776)
  web/admin: fix not being able to unset certificates (#6767)
  policies/reputation: require either check to be enabled (#6764)
  stages/password: fix failed_attempts_before_cancel allowing one too m… (#6763)
  ...
kensternberg-authentik added a commit that referenced this pull request Sep 12, 2023
…-element-to-admin-references

* web/detangling-circular-dependencies: (28 commits)
  root: add option to disable beat when running worker (#6849)
  core: bump ruff from 0.0.287 to 0.0.288 (#6858)
  core: bump goauthentik.io/api/v3 from 3.2023082.6 to 3.2023083.1 (#6859)
  root: fix gunicorn not starting
  providers/saml: set WantAuthnRequestsSigned in metadata (#6851)
  root: fix dumb-init
  web: bump the eslint group in /web with 1 update (#6846)
  web: bump @typescript-eslint/parser from 6.6.0 to 6.7.0 in /web (#6847)
  web: bump API Client version (#6850)
  release: 2023.8.3
  website/docs: prepare 2023.8.3 release notes (#6843)
  core: remove celery's duplicate max_tasks_per_child (#6840)
  providers/scim: check that a provider exists before starting scim task (#6841)
  web/admin: fix flow-search not being able to unset (#6838)
  sources/ldap: dont prefetch useless items (#6812)
  sources/ldap: fix task timeout for ldap_sync_all and ldap_sync_single (#6809)
  root: lock node to 20.5 (#6776)
  web/admin: fix not being able to unset certificates (#6767)
  policies/reputation: require either check to be enabled (#6764)
  stages/password: fix failed_attempts_before_cancel allowing one too m… (#6763)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant