Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

providers/saml: set WantAuthnRequestsSigned in metadata #6851

Merged
merged 1 commit into from Sep 12, 2023

Conversation

BeryJu
Copy link
Member

@BeryJu BeryJu commented Sep 11, 2023

Details

closes #6813


Checklist

  • Local tests pass (ak test authentik/)
  • The code has been formatted (make lint-fix)

If an API change has been made

  • The API schema has been updated (make gen-build)

If changes to the frontend have been made

  • The code has been formatted (make web)
  • The translation files have been updated (make i18n-extract)

If applicable

  • The documentation has been updated
  • The documentation has been formatted (make website)

@BeryJu BeryJu requested a review from a team as a code owner September 11, 2023 20:15
@BeryJu BeryJu requested review from smusali and removed request for a team September 11, 2023 20:15
@netlify
Copy link

netlify bot commented Sep 11, 2023

Deploy Preview for authentik-storybook ready!

Name Link
🔨 Latest commit 46f437b
🔍 Latest deploy log https://app.netlify.com/sites/authentik-storybook/deploys/64ff8d6ca9e3d80008919769
😎 Deploy Preview https://deploy-preview-6851--authentik-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codecov
Copy link

codecov bot commented Sep 11, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +43.31% 🎉

Comparison is base (5b6fb4a) 49.39% compared to head (46f437b) 92.69%.
Report is 4 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #6851       +/-   ##
===========================================
+ Coverage   49.39%   92.69%   +43.31%     
===========================================
  Files         565      565               
  Lines       27784    27794       +10     
===========================================
+ Hits        13722    25762    +12040     
+ Misses      14062     2032    -12030     
Flag Coverage Δ
e2e 51.19% <9.10%> (+3.55%) ⬆️
integration 26.39% <0.00%> (-<0.01%) ⬇️
unit 89.57% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
authentik/providers/saml/processors/metadata.py 100.00% <100.00%> (+77.42%) ⬆️
authentik/providers/saml/tests/test_metadata.py 100.00% <100.00%> (+100.00%) ⬆️

... and 395 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Jens Langhammer <jens@goauthentik.io>
@BeryJu BeryJu force-pushed the providers/saml/set-WantAuthnRequestsSigned branch from 69973f1 to 46f437b Compare September 11, 2023 21:58
@github-actions
Copy link
Contributor

authentik PR Installation instructions

Instructions for docker-compose

Add the following block to your .env file:

AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-providers-saml-set-WantAuthnRequestsSigned-1694470157-46f437b
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s

For arm64, use these values:

AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-providers-saml-set-WantAuthnRequestsSigned-1694470157-46f437b-arm64
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s

Afterwards, run the upgrade commands from the latest release notes.

Instructions for Kubernetes

Add the following block to your values.yml file:

authentik:
    outposts:
        container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
image:
    repository: ghcr.io/goauthentik/dev-server
    tag: gh-providers-saml-set-WantAuthnRequestsSigned-1694470157-46f437b

For arm64, use these values:

authentik:
    outposts:
        container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
image:
    repository: ghcr.io/goauthentik/dev-server
    tag: gh-providers-saml-set-WantAuthnRequestsSigned-1694470157-46f437b-arm64

Afterwards, run the upgrade commands from the latest release notes.

@BeryJu BeryJu merged commit 4c823b7 into main Sep 12, 2023
62 checks passed
@BeryJu BeryJu deleted the providers/saml/set-WantAuthnRequestsSigned branch September 12, 2023 07:10
kensternberg-authentik added a commit that referenced this pull request Sep 12, 2023
* main: (28 commits)
  root: add option to disable beat when running worker (#6849)
  core: bump ruff from 0.0.287 to 0.0.288 (#6858)
  core: bump goauthentik.io/api/v3 from 3.2023082.6 to 3.2023083.1 (#6859)
  root: fix gunicorn not starting
  providers/saml: set WantAuthnRequestsSigned in metadata (#6851)
  root: fix dumb-init
  web: bump the eslint group in /web with 1 update (#6846)
  web: bump @typescript-eslint/parser from 6.6.0 to 6.7.0 in /web (#6847)
  web: bump API Client version (#6850)
  release: 2023.8.3
  website/docs: prepare 2023.8.3 release notes (#6843)
  core: remove celery's duplicate max_tasks_per_child (#6840)
  providers/scim: check that a provider exists before starting scim task (#6841)
  web/admin: fix flow-search not being able to unset (#6838)
  sources/ldap: dont prefetch useless items (#6812)
  sources/ldap: fix task timeout for ldap_sync_all and ldap_sync_single (#6809)
  root: lock node to 20.5 (#6776)
  web/admin: fix not being able to unset certificates (#6767)
  policies/reputation: require either check to be enabled (#6764)
  stages/password: fix failed_attempts_before_cancel allowing one too m… (#6763)
  ...
kensternberg-authentik added a commit that referenced this pull request Sep 12, 2023
…-element-to-admin-references

* web/detangling-circular-dependencies: (28 commits)
  root: add option to disable beat when running worker (#6849)
  core: bump ruff from 0.0.287 to 0.0.288 (#6858)
  core: bump goauthentik.io/api/v3 from 3.2023082.6 to 3.2023083.1 (#6859)
  root: fix gunicorn not starting
  providers/saml: set WantAuthnRequestsSigned in metadata (#6851)
  root: fix dumb-init
  web: bump the eslint group in /web with 1 update (#6846)
  web: bump @typescript-eslint/parser from 6.6.0 to 6.7.0 in /web (#6847)
  web: bump API Client version (#6850)
  release: 2023.8.3
  website/docs: prepare 2023.8.3 release notes (#6843)
  core: remove celery's duplicate max_tasks_per_child (#6840)
  providers/scim: check that a provider exists before starting scim task (#6841)
  web/admin: fix flow-search not being able to unset (#6838)
  sources/ldap: dont prefetch useless items (#6812)
  sources/ldap: fix task timeout for ldap_sync_all and ldap_sync_single (#6809)
  root: lock node to 20.5 (#6776)
  web/admin: fix not being able to unset certificates (#6767)
  policies/reputation: require either check to be enabled (#6764)
  stages/password: fix failed_attempts_before_cancel allowing one too m… (#6763)
  ...
@BeryJu
Copy link
Member Author

BeryJu commented Sep 13, 2023

/cherry-pick version-2023.8

BeryJu added a commit that referenced this pull request Sep 13, 2023
…6851) (#6880)

providers/saml: set WantAuthnRequestsSigned in metadata (#6851)

Co-authored-by: Jens L <jens@goauthentik.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant