Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

root: replace boj/redistore with vendored version of rbcervilla/redisstore #6988

Merged
merged 2 commits into from Sep 26, 2023

Conversation

BeryJu
Copy link
Member

@BeryJu BeryJu commented Sep 26, 2023

Details

#6334

boj/redistore#65

Replace https://github.com/boj/redistore with https://github.com/rbcervilla/redisstore

rbcervilla/redisstore has been vendored as we needed to make some minor changes (make the Redis client accessible for the session cleanup)


Checklist

  • Local tests pass (ak test authentik/)
  • The code has been formatted (make lint-fix)

If an API change has been made

  • The API schema has been updated (make gen-build)

If changes to the frontend have been made

  • The code has been formatted (make web)
  • The translation files have been updated (make i18n-extract)

If applicable

  • The documentation has been updated
  • The documentation has been formatted (make website)

…store

Signed-off-by: Jens Langhammer <jens@goauthentik.io>
@BeryJu BeryJu requested review from a team as code owners September 26, 2023 11:26
@netlify
Copy link

netlify bot commented Sep 26, 2023

Deploy Preview for authentik-storybook canceled.

Name Link
🔨 Latest commit 455cee0
🔍 Latest deploy log https://app.netlify.com/sites/authentik-storybook/deploys/6512c87bbfa6e500096b5caf

@netlify
Copy link

netlify bot commented Sep 26, 2023

Deploy Preview for authentik ready!

Name Link
🔨 Latest commit 7449023
🔍 Latest deploy log https://app.netlify.com/sites/authentik/deploys/6512c0027aa04d00080b1cd4
😎 Deploy Preview https://deploy-preview-6988--authentik.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 96 (no change from production)
Accessibility: 90 (no change from production)
Best Practices: 100 (no change from production)
SEO: 80 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@codecov
Copy link

codecov bot commented Sep 26, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (e807f9f) 44.71% compared to head (455cee0) 92.70%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #6988       +/-   ##
===========================================
+ Coverage   44.71%   92.70%   +47.99%     
===========================================
  Files         567      567               
  Lines       27959    27959               
===========================================
+ Hits        12500    25917    +13417     
+ Misses      15459     2042    -13417     
Flag Coverage Δ
e2e 51.19% <ø> (+6.49%) ⬆️
integration 26.27% <ø> (?)
unit 89.61% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 423 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 26, 2023

authentik PR Installation instructions

Instructions for docker-compose

Add the following block to your .env file:

AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-root-migrate-go-redis-1695732122-455cee0
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s

For arm64, use these values:

AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-root-migrate-go-redis-1695732122-455cee0-arm64
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s

Afterwards, run the upgrade commands from the latest release notes.

Instructions for Kubernetes

Add the following block to your values.yml file:

authentik:
    outposts:
        container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
image:
    repository: ghcr.io/goauthentik/dev-server
    tag: gh-root-migrate-go-redis-1695732122-455cee0

For arm64, use these values:

authentik:
    outposts:
        container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
image:
    repository: ghcr.io/goauthentik/dev-server
    tag: gh-root-migrate-go-redis-1695732122-455cee0-arm64

Afterwards, run the upgrade commands from the latest release notes.

Signed-off-by: Jens Langhammer <jens@goauthentik.io>
@BeryJu BeryJu requested a review from a team as a code owner September 26, 2023 12:03
@BeryJu BeryJu merged commit c93c6ee into main Sep 26, 2023
60 checks passed
@BeryJu BeryJu deleted the root/migrate-go-redis branch September 26, 2023 16:56
kensternberg-authentik added a commit that referenced this pull request Sep 27, 2023
* main: (41 commits)
  root: fix missing /lifecycle in path
  website/blog: add info-block to blog about m2m (#7002)
  root: handle SIGHUP and SIGUSR2, healthcheck gunicorn (#6630)
  flows: stage_invalid() makes flow restart depending on invalid_response_action setting (#6780)
  core: bump psycopg from 3.1.11 to 3.1.12 (#6997)
  core: bump pydantic from 2.4.0 to 2.4.1 (#6998)
  web: bump the sentry group in /web with 2 updates (#6999)
  web: bump pyright from 1.1.328 to 1.1.329 in /web (#7000)
  website/blog: improved sentence (#6995)
  website/blog: fix missing link in m2m post (#6994)
  web/user: fix incorrect link to admin interface (#6993)
  root: disable APPEND_SLASH (#6928)
  root: replace boj/redistore with vendored version of rbcervilla/redisstore (#6988)
  sources/ldap: add default property mapping to mirror directory structure (#6990)
  website/blogs: Blog about m2m (#6974)
  root: make Celery worker concurrency configurable (#6837)
  root: make postgres connection in makefile customizable (#6977)
  core: prevent self-impersonation (#6885)
  web: bump @typescript-eslint/parser from 6.7.2 to 6.7.3 in /web (#6984)
  core: bump pydantic from 2.3.0 to 2.4.0 (#6979)
  ...
BeryJu added a commit that referenced this pull request Sep 28, 2023
…la/redisstore (#6988)"

This reverts commit c93c6ee.

Signed-off-by: Jens Langhammer <jens@goauthentik.io>

# Conflicts:
#	go.mod
#	go.sum
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant