Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

providers/scim: remove preview #7166

Merged
merged 1 commit into from Oct 13, 2023
Merged

providers/scim: remove preview #7166

merged 1 commit into from Oct 13, 2023

Conversation

BeryJu
Copy link
Member

@BeryJu BeryJu commented Oct 13, 2023

Details

the SCIM provider has been around for a while and is stable so remove the preview annotation


Checklist

  • Local tests pass (ak test authentik/)
  • The code has been formatted (make lint-fix)

If an API change has been made

  • The API schema has been updated (make gen-build)

If changes to the frontend have been made

  • The code has been formatted (make web)
  • The translation files have been updated (make i18n-extract)

If applicable

  • The documentation has been updated
  • The documentation has been formatted (make website)

Signed-off-by: Jens Langhammer <jens@goauthentik.io>
@BeryJu BeryJu requested review from a team as code owners October 13, 2023 16:27
@netlify
Copy link

netlify bot commented Oct 13, 2023

Deploy Preview for authentik-storybook ready!

Name Link
🔨 Latest commit f8ca941
🔍 Latest deploy log https://app.netlify.com/sites/authentik-storybook/deploys/65296fe1a0bbe30008ea581e
😎 Deploy Preview https://deploy-preview-7166--authentik-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Oct 13, 2023

Deploy Preview for authentik ready!

Name Link
🔨 Latest commit f8ca941
🔍 Latest deploy log https://app.netlify.com/sites/authentik/deploys/65296fe1ec9ba500095ad8f9
😎 Deploy Preview https://deploy-preview-7166--authentik.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 96 (no change from production)
Accessibility: 90 (no change from production)
Best Practices: 100 (no change from production)
SEO: 80 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@codecov
Copy link

codecov bot commented Oct 13, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (63a9cf2) 92.64% compared to head (f8ca941) 92.67%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7166      +/-   ##
==========================================
+ Coverage   92.64%   92.67%   +0.04%     
==========================================
  Files         568      568              
  Lines       28049    28049              
==========================================
+ Hits        25983    25993      +10     
+ Misses       2066     2056      -10     
Flag Coverage Δ
e2e 51.19% <ø> (+0.04%) ⬆️
integration 26.34% <ø> (ø)
unit 89.57% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 4 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions
Copy link
Contributor

authentik PR Installation instructions

Instructions for docker-compose

Add the following block to your .env file:

AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-providers-scim-remove-preview-1697215269-f8ca941
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s

For arm64, use these values:

AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-providers-scim-remove-preview-1697215269-f8ca941-arm64
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s

Afterwards, run the upgrade commands from the latest release notes.

Instructions for Kubernetes

Add the following block to your values.yml file:

authentik:
    outposts:
        container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
image:
    repository: ghcr.io/goauthentik/dev-server
    tag: gh-providers-scim-remove-preview-1697215269-f8ca941

For arm64, use these values:

authentik:
    outposts:
        container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
image:
    repository: ghcr.io/goauthentik/dev-server
    tag: gh-providers-scim-remove-preview-1697215269-f8ca941-arm64

Afterwards, run the upgrade commands from the latest release notes.

@BeryJu BeryJu merged commit 41bb1ca into main Oct 13, 2023
63 checks passed
@BeryJu BeryJu deleted the providers/scim/remove-preview branch October 13, 2023 17:03
kensternberg-authentik added a commit that referenced this pull request Oct 13, 2023
There were some HEAVY merge bugs in the translation files.

* main:
  providers/scim: remove preview (#7166)
  web: bump the wdio group in /tests/wdio with 4 updates (#7160)
  translate: Updates for file web/xliff/en.xlf in zh_CN (#7162)
  translate: Updates for file web/xliff/en.xlf in zh-Hans (#7161)
  translate: Updates for file web/xliff/en.xlf in zh-Hans (#7158)
  website/docs: Balok pr for User docs (#7139)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant