Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

events: fix gdpr compliance always running #7491

Merged
merged 1 commit into from Nov 8, 2023
Merged

Conversation

rissson
Copy link
Member

@rissson rissson commented Nov 8, 2023

Details

REPLACE ME


Checklist

  • Local tests pass (ak test authentik/)
  • The code has been formatted (make lint-fix)

If an API change has been made

  • The API schema has been updated (make gen-build)

If changes to the frontend have been made

  • The code has been formatted (make web)
  • The translation files have been updated (make i18n-extract)

If applicable

  • The documentation has been updated
  • The documentation has been formatted (make website)

Signed-off-by: Marc 'risson' Schmitt <marc.schmitt@risson.space>
@rissson rissson self-assigned this Nov 8, 2023
@rissson rissson requested a review from a team as a code owner November 8, 2023 14:07
Copy link

netlify bot commented Nov 8, 2023

Deploy Preview for authentik-storybook ready!

Name Link
🔨 Latest commit 7fe8e88
🔍 Latest deploy log https://app.netlify.com/sites/authentik-storybook/deploys/654b96391fc403000870ff12
😎 Deploy Preview https://deploy-preview-7491--authentik-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Nov 8, 2023

Deploy Preview for authentik ready!

Name Link
🔨 Latest commit 7fe8e88
🔍 Latest deploy log https://app.netlify.com/sites/authentik/deploys/654b9639cf8869000879ad1f
😎 Deploy Preview https://deploy-preview-7491--authentik.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 96 (🔴 down 1 from production)
Accessibility: 90 (no change from production)
Best Practices: 100 (no change from production)
SEO: 80 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@rissson rissson enabled auto-merge (rebase) November 8, 2023 14:09
Copy link

codecov bot commented Nov 8, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (cc1c66a) 92.59% compared to head (7fe8e88) 92.15%.
Report is 6 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7491      +/-   ##
==========================================
- Coverage   92.59%   92.15%   -0.44%     
==========================================
  Files         587      587              
  Lines       28898    28900       +2     
==========================================
- Hits        26757    26633     -124     
- Misses       2141     2267     +126     
Flag Coverage Δ
e2e 49.29% <33.33%> (-1.66%) ⬇️
integration 26.01% <33.33%> (+<0.01%) ⬆️
unit 89.59% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
authentik/events/signals.py 100.00% <100.00%> (ø)

... and 14 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rissson rissson merged commit 2d821a0 into main Nov 8, 2023
64 of 66 checks passed
@rissson rissson deleted the fix-gdpr-compliance branch November 8, 2023 14:19
@rissson
Copy link
Member Author

rissson commented Nov 9, 2023

/cherry-pick version-2023.10

BeryJu pushed a commit that referenced this pull request Nov 9, 2023
events: fix gdpr compliance always running

Signed-off-by: Marc 'risson' Schmitt <marc.schmitt@risson.space>
Co-authored-by: Marc 'risson' Schmitt <marc.schmitt@risson.space>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants