Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

providers/proxy: Fix duplicate cookies when using file system store. #7541

Merged
merged 1 commit into from Nov 13, 2023

Conversation

thijsa
Copy link
Contributor

@thijsa thijsa commented Nov 13, 2023

Details

#7435 and #7374 when using file system store (default when using outpost docker image).


Checklist

  • Local tests pass (ak test authentik/)
  • The code has been formatted (make lint-fix)

If an API change has been made

  • The API schema has been updated (make gen-build)

If changes to the frontend have been made

  • The code has been formatted (make web)
  • The translation files have been updated (make i18n-extract)

If applicable

  • The documentation has been updated
  • The documentation has been formatted (make website)

@thijsa thijsa requested a review from a team as a code owner November 13, 2023 12:04
Copy link

netlify bot commented Nov 13, 2023

Deploy Preview for authentik-storybook ready!

Name Link
🔨 Latest commit c79e8e9
🔍 Latest deploy log https://app.netlify.com/sites/authentik-storybook/deploys/65523220cf70a600080a6353
😎 Deploy Preview https://deploy-preview-7541--authentik-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@BeryJu BeryJu changed the title Fix duplicate cookies when using file system store. providers/proxy: Fix duplicate cookies when using file system store. Nov 13, 2023
Copy link
Member

@BeryJu BeryJu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huh I thought the redirect-loop only happens with the embedded outpost

@BeryJu
Copy link
Member

BeryJu commented Nov 13, 2023

/cherry-pick version-2023.10

@thijsa
Copy link
Contributor Author

thijsa commented Nov 13, 2023

@BeryJu I don't use the embedded outpost but when I setup my local env I didn't get the issue using the embedded outpost. We encountered the loop on the external outpost, it sets the cookie twice, on / and on /outpost.goauthentik.io.

Copy link

codecov bot commented Nov 13, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (0e019e1) 92.59% compared to head (c79e8e9) 48.55%.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #7541       +/-   ##
===========================================
- Coverage   92.59%   48.55%   -44.04%     
===========================================
  Files         587      587               
  Lines       29029    29029               
===========================================
- Hits        26879    14095    -12784     
- Misses       2150    14934    +12784     
Flag Coverage Δ
e2e 48.55% <ø> (-2.25%) ⬇️
integration ?
unit ?

Flags with carried forward coverage won't be shown. Click here to find out more.

see 425 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@BeryJu BeryJu force-pushed the bugfix/duplicate-session-cookie-fix branch from b0d5f2f to c79e8e9 Compare November 13, 2023 14:26
@BeryJu BeryJu merged commit 6957195 into goauthentik:main Nov 13, 2023
59 of 60 checks passed
gcp-cherry-pick-bot bot pushed a commit that referenced this pull request Nov 13, 2023
…7541)

Fix duplicate cookies when using file system store.
BeryJu pushed a commit that referenced this pull request Nov 13, 2023
…(cherry-pick #7541) (#7544)

providers/proxy: Fix duplicate cookies when using file system store. (#7541)

Fix duplicate cookies when using file system store.

Co-authored-by: thijs_a <thijs@thijsalders.nl>
kensternberg-authentik added a commit that referenced this pull request Nov 14, 2023
* main: (24 commits)
  internal: remove special route for /outpost.goauthentik.io (#7539)
  providers/proxy: Fix duplicate cookies when using file system store. (#7541)
  web: bump API Client version (#7543)
  sources/ldap: add check command to verify ldap connectivity (#7263)
  internal: remove deprecated metrics (#7540)
  core: compile backend translations (#7538)
  web: bump prettier from 3.0.3 to 3.1.0 in /web (#7528)
  web: bump @trivago/prettier-plugin-sort-imports from 4.2.1 to 4.3.0 in /web (#7531)
  web: bump rollup from 4.3.0 to 4.4.0 in /web (#7529)
  core: bump celery from 5.3.4 to 5.3.5 (#7536)
  web: bump @formatjs/intl-listformat from 7.5.1 to 7.5.2 in /web (#7530)
  web: bump prettier from 3.0.3 to 3.1.0 in /tests/wdio (#7532)
  web: bump @trivago/prettier-plugin-sort-imports from 4.2.1 to 4.3.0 in /tests/wdio (#7533)
  website: bump prettier from 3.0.3 to 3.1.0 in /website (#7534)
  website: bump prism-react-renderer from 2.1.0 to 2.2.0 in /website (#7535)
  translate: Updates for file locale/en/LC_MESSAGES/django.po in zh_TW (#7537)
  root: Restructure broker / cache / channel / result configuration (#7097)
  core: bump twilio from 8.10.0 to 8.10.1 (#7474)
  web: bump axios from 1.5.0 to 1.6.1 in /web (#7518)
  web: bump wdio-wait-for from 3.0.7 to 3.0.8 in /tests/wdio (#7514)
  ...
kensternberg-authentik added a commit that referenced this pull request Nov 17, 2023
* main: (24 commits)
  internal: remove special route for /outpost.goauthentik.io (#7539)
  providers/proxy: Fix duplicate cookies when using file system store. (#7541)
  web: bump API Client version (#7543)
  sources/ldap: add check command to verify ldap connectivity (#7263)
  internal: remove deprecated metrics (#7540)
  core: compile backend translations (#7538)
  web: bump prettier from 3.0.3 to 3.1.0 in /web (#7528)
  web: bump @trivago/prettier-plugin-sort-imports from 4.2.1 to 4.3.0 in /web (#7531)
  web: bump rollup from 4.3.0 to 4.4.0 in /web (#7529)
  core: bump celery from 5.3.4 to 5.3.5 (#7536)
  web: bump @formatjs/intl-listformat from 7.5.1 to 7.5.2 in /web (#7530)
  web: bump prettier from 3.0.3 to 3.1.0 in /tests/wdio (#7532)
  web: bump @trivago/prettier-plugin-sort-imports from 4.2.1 to 4.3.0 in /tests/wdio (#7533)
  website: bump prettier from 3.0.3 to 3.1.0 in /website (#7534)
  website: bump prism-react-renderer from 2.1.0 to 2.2.0 in /website (#7535)
  translate: Updates for file locale/en/LC_MESSAGES/django.po in zh_TW (#7537)
  root: Restructure broker / cache / channel / result configuration (#7097)
  core: bump twilio from 8.10.0 to 8.10.1 (#7474)
  web: bump axios from 1.5.0 to 1.6.1 in /web (#7518)
  web: bump wdio-wait-for from 3.0.7 to 3.0.8 in /tests/wdio (#7514)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants