tests: fix flaky tests #7676
Merged
tests: fix flaky tests #7676
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jens Langhammer <jens@goauthentik.io>
✅ Deploy Preview for authentik-storybook canceled.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7676 +/- ##
==========================================
- Coverage 92.64% 92.63% -0.01%
==========================================
Files 588 588
Lines 29140 29140
==========================================
- Hits 26997 26995 -2
- Misses 2143 2145 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Jens Langhammer <jens@goauthentik.io>
Signed-off-by: Jens Langhammer <jens@goauthentik.io>
Signed-off-by: Jens Langhammer <jens@goauthentik.io>
Signed-off-by: Jens Langhammer <jens@goauthentik.io>
|
/cherry-pick version-2023.10 |
gcp-cherry-pick-bot bot
pushed a commit
that referenced
this pull request
Dec 19, 2023
* tests: fix flaky tests Signed-off-by: Jens Langhammer <jens@goauthentik.io> * make test-from-stable use actual latest version Signed-off-by: Jens Langhammer <jens@goauthentik.io> * fix checkout Signed-off-by: Jens Langhammer <jens@goauthentik.io> * remove hardcoded seed Signed-off-by: Jens Langhammer <jens@goauthentik.io> * ignore tests for now i guess idk Signed-off-by: Jens Langhammer <jens@goauthentik.io> --------- Signed-off-by: Jens Langhammer <jens@goauthentik.io>
BeryJu
added a commit
that referenced
this pull request
Dec 19, 2023
tests: fix flaky tests (#7676) * tests: fix flaky tests * make test-from-stable use actual latest version * fix checkout * remove hardcoded seed * ignore tests for now i guess idk --------- Signed-off-by: Jens Langhammer <jens@goauthentik.io> Co-authored-by: Jens L <jens@goauthentik.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
So the Docker API takes healthcheck intervals/delays as nanoseconds (most likely due to the Golang's handling of time/duration), and the containers in our e2e tests should've been using a 5s initial delay and then a 5s interval. However due to maths being...hard, they were actually being healthchecked every 500ms, due to a missing 0.
I'm honestly surprised this hasn't broken more things, although I suppose we'll never know how many test failures this caused by hogging all the CPU to do healthchecks.
The main culprit that brought this to light was
docker:dind, which would crash consistently (at least locally) with those insane intervals set.Checklist
ak test authentik/)make lint-fix)If an API change has been made
make gen-build)If changes to the frontend have been made
make web)make i18n-extract)If applicable
make website)