Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

web: dark/light theme fixes #7872

Merged
merged 5 commits into from Dec 13, 2023
Merged

web: dark/light theme fixes #7872

merged 5 commits into from Dec 13, 2023

Conversation

BeryJu
Copy link
Member

@BeryJu BeryJu commented Dec 13, 2023

Details

closes #7754

Affects forced light theme:

  • move global theme-dark css to only use for SSR rendered pages

Affects forced dark theme:

  • fix missing fallback not showing default slant
  • fix header button colors
  • web: fix css for user tree-view

And some other small stuff

  • fix unrelated things

Checklist

  • Local tests pass (ak test authentik/)
  • The code has been formatted (make lint-fix)

If an API change has been made

  • The API schema has been updated (make gen-build)

If changes to the frontend have been made

  • The code has been formatted (make web)
  • The translation files have been updated (make i18n-extract)

If applicable

  • The documentation has been updated
  • The documentation has been formatted (make website)

Signed-off-by: Jens Langhammer <jens@goauthentik.io>
Signed-off-by: Jens Langhammer <jens@goauthentik.io>
Signed-off-by: Jens Langhammer <jens@goauthentik.io>
Signed-off-by: Jens Langhammer <jens@goauthentik.io>
Signed-off-by: Jens Langhammer <jens@goauthentik.io>
@BeryJu BeryJu requested review from a team as code owners December 13, 2023 15:52
Copy link

netlify bot commented Dec 13, 2023

Deploy Preview for authentik-storybook ready!

Name Link
🔨 Latest commit 1603d55
🔍 Latest deploy log https://app.netlify.com/sites/authentik-storybook/deploys/6579d32f59119500088a5762
😎 Deploy Preview https://deploy-preview-7872--authentik-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

authentik translations instructions

Thanks for your pull request!

authentik translations are handled using Transifex. Please edit translations over there and they'll be included automatically.

Copy link

codecov bot commented Dec 13, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (026e80b) 92.62% compared to head (1603d55) 92.63%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7872   +/-   ##
=======================================
  Coverage   92.62%   92.63%           
=======================================
  Files         588      588           
  Lines       29200    29200           
=======================================
+ Hits        27047    27049    +2     
+ Misses       2153     2151    -2     
Flag Coverage Δ
e2e 50.65% <ø> (+<0.01%) ⬆️
integration 25.91% <ø> (ø)
unit 89.70% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@BeryJu BeryJu merged commit 2337f5a into main Dec 13, 2023
67 checks passed
@BeryJu BeryJu deleted the web/css-fixes branch December 13, 2023 16:32
@BeryJu
Copy link
Member Author

BeryJu commented Dec 19, 2023

/cherry-pick version-2023.10

Copy link

Cherry-pick failed with Merge error 2337f5a173cfa4b34979effcc15459318ae0f59e into temp-cherry-pick-6c6d67-version-2023.10

BeryJu added a commit that referenced this pull request Dec 19, 2023
* web: fix css for user tree-view

Signed-off-by: Jens Langhammer <jens@goauthentik.io>

* fix unrelated things

Signed-off-by: Jens Langhammer <jens@goauthentik.io>

* fix header button colors

Signed-off-by: Jens Langhammer <jens@goauthentik.io>

* fix missing fallback not showing default slant

Signed-off-by: Jens Langhammer <jens@goauthentik.io>

* move global theme-dark css to only use for SSR rendered pages

Signed-off-by: Jens Langhammer <jens@goauthentik.io>

---------

Signed-off-by: Jens Langhammer <jens@goauthentik.io>
# Conflicts:
#	.github/workflows/ci-main.yml
#	web/xliff/fr.xlf
kensternberg-authentik added a commit that referenced this pull request Jan 8, 2024
* main:
  web: dark/light theme fixes (#7872)
  web: replace 'description-list' with list of descriptions (#7392)
  web: expressing success (#7830)
  web: fix turnstile types after update (#7854)
  core: bump github.com/google/uuid from 1.4.0 to 1.5.0 (#7866)
  website: bump @types/react from 18.2.43 to 18.2.45 in /website (#7865)
  web: bump wdio-wait-for from 3.0.9 to 3.0.10 in /tests/wdio (#7867)
  website/blog: okta part two blog (#7863)
  web: bump lit-analyzer from 2.0.1 to 2.0.2 in /web (#7858)
  web: bump the babel group in /web with 4 updates (#7856)
  web: bump the eslint group in /web with 2 updates (#7857)
  web: bump rollup from 4.7.0 to 4.8.0 in /web (#7859)
  web: bump the eslint group in /tests/wdio with 2 updates (#7860)
  web: refactor the table renderer for legibility  (#7433)
  documentation: Improve explanation of `kubernetes_json_patches` (#7832)
  root: update security policy to include link to cure53 report (#7853)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Broken styles when Authentik theme is set to Light but OS theme is Dark
1 participant