Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stages/user_login: session binding #7881

Merged
merged 6 commits into from Dec 23, 2023
Merged

stages/user_login: session binding #7881

merged 6 commits into from Dec 23, 2023

Conversation

BeryJu
Copy link
Member

@BeryJu BeryJu commented Dec 14, 2023

Details

(This builds on top of the ASN context processor)

Add the ability to bind sessions (and further on OAuth tokens) to ASN/Network/IP/Continent/Country/City


Checklist

  • Local tests pass (ak test authentik/)
  • The code has been formatted (make lint-fix)

If an API change has been made

  • The API schema has been updated (make gen-build)

If changes to the frontend have been made

  • The code has been formatted (make web)
  • The translation files have been updated (make i18n-extract)

If applicable

  • The documentation has been updated
  • The documentation has been formatted (make website)

@BeryJu BeryJu requested review from a team as code owners December 14, 2023 12:54
Copy link

netlify bot commented Dec 14, 2023

Deploy Preview for authentik-storybook canceled.

Name Link
🔨 Latest commit 6f3ed54
🔍 Latest deploy log https://app.netlify.com/sites/authentik-storybook/deploys/658621b61479f90008f1ad1b

Copy link

codecov bot commented Dec 14, 2023

Codecov Report

Attention: 51 lines in your changes are missing coverage. Please review.

Comparison is base (23c03d4) 92.59% compared to head (6f3ed54) 92.46%.
Report is 1 commits behind head on main.

Files Patch % Lines
authentik/stages/user_login/middleware.py 44.82% 48 Missing ⚠️
authentik/events/context_processors/asn.py 75.00% 1 Missing ⚠️
authentik/events/context_processors/geoip.py 75.00% 1 Missing ⚠️
authentik/events/signals.py 80.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7881      +/-   ##
==========================================
- Coverage   92.59%   92.46%   -0.14%     
==========================================
  Files         593      594       +1     
  Lines       29402    29523     +121     
==========================================
+ Hits        27224    27297      +73     
- Misses       2178     2226      +48     
Flag Coverage Δ
e2e 50.79% <58.20%> (+0.08%) ⬆️
integration 26.18% <35.82%> (+0.03%) ⬆️
unit 89.56% <61.94%> (-0.14%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Task

Copy link

netlify bot commented Dec 20, 2023

Deploy Preview for authentik ready!

Name Link
🔨 Latest commit e0e5546
🔍 Latest deploy log https://app.netlify.com/sites/authentik/deploys/6586211935378900081230e0
😎 Deploy Preview https://deploy-preview-7881--authentik.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@BeryJu BeryJu requested a review from a team as a code owner December 22, 2023 22:58
Signed-off-by: Jens Langhammer <jens@goauthentik.io>

# Conflicts:
#	authentik/root/settings.py
Signed-off-by: Jens Langhammer <jens@goauthentik.io>
Signed-off-by: Jens Langhammer <jens@goauthentik.io>
Signed-off-by: Jens Langhammer <jens@goauthentik.io>
Signed-off-by: Jens Langhammer <jens@goauthentik.io>
Signed-off-by: Jens Langhammer <jens@goauthentik.io>
@BeryJu BeryJu changed the title core: token/session binding stages/user_login: token/session binding Dec 23, 2023
@BeryJu BeryJu changed the title stages/user_login: token/session binding stages/user_login: session binding Dec 23, 2023
@BeryJu BeryJu enabled auto-merge (squash) December 23, 2023 00:20
@BeryJu BeryJu disabled auto-merge December 23, 2023 00:20
@BeryJu BeryJu merged commit 02869d8 into main Dec 23, 2023
63 of 65 checks passed
@BeryJu BeryJu deleted the core/token-binding branch December 23, 2023 00:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant