Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

providers/scim: set timeout based on page and page count #7941

Merged
merged 1 commit into from Dec 19, 2023

Conversation

BeryJu
Copy link
Member

@BeryJu BeryJu commented Dec 19, 2023

Details

Set total sync timeout based on amount of pages, and set individual page timeout


Checklist

  • Local tests pass (ak test authentik/)
  • The code has been formatted (make lint-fix)

If an API change has been made

  • The API schema has been updated (make gen-build)

If changes to the frontend have been made

  • The code has been formatted (make web)
  • The translation files have been updated (make i18n-extract)

If applicable

  • The documentation has been updated
  • The documentation has been formatted (make website)

Signed-off-by: Jens Langhammer <jens@goauthentik.io>
@BeryJu BeryJu requested a review from a team as a code owner December 19, 2023 23:12
Copy link

netlify bot commented Dec 19, 2023

Deploy Preview for authentik-storybook canceled.

Name Link
🔨 Latest commit a1a8833
🔍 Latest deploy log https://app.netlify.com/sites/authentik-storybook/deploys/658223652bb5160008f4ce15

Copy link

codecov bot commented Dec 19, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2d3b4ad) 92.64% compared to head (a1a8833) 92.64%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7941   +/-   ##
=======================================
  Coverage   92.64%   92.64%           
=======================================
  Files         589      589           
  Lines       29269    29271    +2     
=======================================
+ Hits        27117    27119    +2     
  Misses       2152     2152           
Flag Coverage Δ
e2e 50.63% <75.00%> (-0.01%) ⬇️
integration 26.04% <75.00%> (+<0.01%) ⬆️
unit 89.73% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@BeryJu BeryJu merged commit 0bf84b7 into main Dec 19, 2023
66 checks passed
@BeryJu BeryJu deleted the providers/scim/set-better-timeout branch December 19, 2023 23:40
kensternberg-authentik added a commit that referenced this pull request Dec 21, 2023
* main: (21 commits)
  web: bump API Client version (#7964)
  release: 2023.10.5
  web: bump API Client version (#7962)
  providers/scim: use lock for sync (#7948)
  stages/email: prevent authentik emails from being marked as spam (also add text template support) (#7949)
  website/docs: prepare 2023.10.5 (#7947)
  web: bump the sentry group in /web with 2 updates (#7955)
  web: bump the wdio group in /tests/wdio with 4 updates (#7957)
  core: bump goauthentik.io/api/v3 from 3.2023104.4 to 3.2023104.5 (#7958)
  web: bump API Client version (#7953)
  events: add ASN Database reader (#7793)
  translate: Updates for file web/xliff/en.xlf in fr (#7951)
  website/docs: add expression example for geoip (#7739)
  website: fix hosted API browser (#7946)
  core: bump github.com/redis/go-redis/v9 from 9.3.0 to 9.3.1 (#7942)
  web: bump the sentry group in /web with 2 updates (#7944)
  web: bump the storybook group in /web with 7 updates (#7945)
  core: bump goauthentik.io/api/v3 from 3.2023104.3 to 3.2023104.4 (#7943)
  providers/scim: set timeout based on page and page count (#7941)
  translate: Updates for file web/xliff/en.xlf in zh_CN (#7928)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants