Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

providers/scim: use lock for sync #7948

Merged
merged 2 commits into from Dec 21, 2023
Merged

providers/scim: use lock for sync #7948

merged 2 commits into from Dec 21, 2023

Conversation

BeryJu
Copy link
Member

@BeryJu BeryJu commented Dec 20, 2023

Details

Similar to LDAP sync, use a redis lock


Checklist

  • Local tests pass (ak test authentik/)
  • The code has been formatted (make lint-fix)

If an API change has been made

  • The API schema has been updated (make gen-build)

If changes to the frontend have been made

  • The code has been formatted (make web)
  • The translation files have been updated (make i18n-extract)

If applicable

  • The documentation has been updated
  • The documentation has been formatted (make website)

Signed-off-by: Jens Langhammer <jens@goauthentik.io>
@BeryJu BeryJu requested review from a team as code owners December 20, 2023 13:06
Copy link

netlify bot commented Dec 20, 2023

Deploy Preview for authentik-storybook canceled.

Name Link
🔨 Latest commit 7d66e99
🔍 Latest deploy log https://app.netlify.com/sites/authentik-storybook/deploys/65836a282008210008c031f3

Copy link
Contributor

authentik translations instructions

Thanks for your pull request!

authentik translations are handled using Transifex. Please edit translations over there and they'll be included automatically.

Copy link

codecov bot commented Dec 20, 2023

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (6628088) 92.64% compared to head (7d66e99) 92.60%.
Report is 4 commits behind head on main.

Files Patch % Lines
authentik/providers/scim/api/providers.py 55.55% 4 Missing ⚠️
authentik/providers/scim/tasks.py 50.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7948      +/-   ##
==========================================
- Coverage   92.64%   92.60%   -0.05%     
==========================================
  Files         589      593       +4     
  Lines       29271    29387     +116     
==========================================
+ Hits        27119    27214      +95     
- Misses       2152     2173      +21     
Flag Coverage Δ
e2e 50.70% <52.63%> (+0.06%) ⬆️
integration 26.12% <26.31%> (+0.07%) ⬆️
unit 89.69% <68.42%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Jens Langhammer <jens@goauthentik.io>
Copy link

netlify bot commented Dec 20, 2023

Deploy Preview for authentik ready!

Name Link
🔨 Latest commit 7d66e99
🔍 Latest deploy log https://app.netlify.com/sites/authentik/deploys/65836a28f580f40008da4ba5
😎 Deploy Preview https://deploy-preview-7948--authentik.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@BeryJu BeryJu merged commit 2521073 into main Dec 21, 2023
65 of 66 checks passed
@BeryJu BeryJu deleted the providers/scim/lock branch December 21, 2023 13:43
kensternberg-authentik added a commit that referenced this pull request Dec 21, 2023
* main: (21 commits)
  web: bump API Client version (#7964)
  release: 2023.10.5
  web: bump API Client version (#7962)
  providers/scim: use lock for sync (#7948)
  stages/email: prevent authentik emails from being marked as spam (also add text template support) (#7949)
  website/docs: prepare 2023.10.5 (#7947)
  web: bump the sentry group in /web with 2 updates (#7955)
  web: bump the wdio group in /tests/wdio with 4 updates (#7957)
  core: bump goauthentik.io/api/v3 from 3.2023104.4 to 3.2023104.5 (#7958)
  web: bump API Client version (#7953)
  events: add ASN Database reader (#7793)
  translate: Updates for file web/xliff/en.xlf in fr (#7951)
  website/docs: add expression example for geoip (#7739)
  website: fix hosted API browser (#7946)
  core: bump github.com/redis/go-redis/v9 from 9.3.0 to 9.3.1 (#7942)
  web: bump the sentry group in /web with 2 updates (#7944)
  web: bump the storybook group in /web with 7 updates (#7945)
  core: bump goauthentik.io/api/v3 from 3.2023104.3 to 3.2023104.4 (#7943)
  providers/scim: set timeout based on page and page count (#7941)
  translate: Updates for file web/xliff/en.xlf in zh_CN (#7928)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant