Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stages/authenticator_validate: use friendly_name for stage selector when enrolling #8255

Merged
merged 2 commits into from Jan 22, 2024

Conversation

BeryJu
Copy link
Member

@BeryJu BeryJu commented Jan 22, 2024

Details

#8154


Checklist

  • Local tests pass (ak test authentik/)
  • The code has been formatted (make lint-fix)

If an API change has been made

  • The API schema has been updated (make gen-build)

If changes to the frontend have been made

  • The code has been formatted (make web)
  • The translation files have been updated (make i18n-extract)

If applicable

  • The documentation has been updated
  • The documentation has been formatted (make website)

…hen enrolling

Signed-off-by: Jens Langhammer <jens@goauthentik.io>
@BeryJu BeryJu requested a review from a team as a code owner January 22, 2024 12:22
Copy link

netlify bot commented Jan 22, 2024

Deploy Preview for authentik-storybook canceled.

Name Link
🔨 Latest commit e6b19e5
🔍 Latest deploy log https://app.netlify.com/sites/authentik-storybook/deploys/65ae74795fa43b0008fae2b7

@BeryJu
Copy link
Member Author

BeryJu commented Jan 22, 2024

/cherry-pick version-2023.10

Copy link

codecov bot commented Jan 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6dd2fc3) 92.32% compared to head (e6b19e5) 92.18%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8255      +/-   ##
==========================================
- Coverage   92.32%   92.18%   -0.14%     
==========================================
  Files         608      608              
  Lines       30262    30265       +3     
==========================================
- Hits        27938    27900      -38     
- Misses       2324     2365      +41     
Flag Coverage Δ
e2e 49.31% <20.00%> (-1.30%) ⬇️
integration 26.39% <20.00%> (-0.01%) ⬇️
unit 89.50% <100.00%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Jens Langhammer <jens@goauthentik.io>
Copy link
Contributor

authentik PR Installation instructions

Instructions for docker-compose

Add the following block to your .env file:

AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-stages-authenticator_validate-use-friendly-name-enroll-1705935516-e6b19e5
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s

For arm64, use these values:

AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-stages-authenticator_validate-use-friendly-name-enroll-1705935516-e6b19e5-arm64
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s

Afterwards, run the upgrade commands from the latest release notes.

Instructions for Kubernetes

Add the following block to your values.yml file:

authentik:
    outposts:
        container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
image:
    repository: ghcr.io/goauthentik/dev-server
    tag: gh-stages-authenticator_validate-use-friendly-name-enroll-1705935516-e6b19e5

For arm64, use these values:

authentik:
    outposts:
        container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
image:
    repository: ghcr.io/goauthentik/dev-server
    tag: gh-stages-authenticator_validate-use-friendly-name-enroll-1705935516-e6b19e5-arm64

Afterwards, run the upgrade commands from the latest release notes.

@BeryJu BeryJu merged commit b1c7c22 into main Jan 22, 2024
69 checks passed
@BeryJu BeryJu deleted the stages/authenticator_validate/use-friendly-name-enroll branch January 22, 2024 15:06
gcp-cherry-pick-bot bot pushed a commit that referenced this pull request Jan 22, 2024
…hen enrolling (#8255)

* stages/authenticator_validate: use friendly_name for stage selector when enrolling

Signed-off-by: Jens Langhammer <jens@goauthentik.io>

* fix tests

Signed-off-by: Jens Langhammer <jens@goauthentik.io>

---------

Signed-off-by: Jens Langhammer <jens@goauthentik.io>
BeryJu added a commit that referenced this pull request Jan 22, 2024
…hen enrolling (cherry-pick #8255) (#8256)

stages/authenticator_validate: use friendly_name for stage selector when enrolling (#8255)

* stages/authenticator_validate: use friendly_name for stage selector when enrolling



* fix tests



---------

Signed-off-by: Jens Langhammer <jens@goauthentik.io>
Co-authored-by: Jens L <jens@goauthentik.io>
kensternberg-authentik added a commit that referenced this pull request Jan 22, 2024
* main: (21 commits)
  stages/authenticator_validate: use friendly_name for stage selector when enrolling (#8255)
  web: bump vite from 5.0.10 to 5.0.12 in /web (#8241)
  web: bump the wdio group in /tests/wdio with 4 updates (#8253)
  web: bump rollup from 4.9.5 to 4.9.6 in /web (#8251)
  web: bump core-js from 3.35.0 to 3.35.1 in /web (#8250)
  web: bump the sentry group in /web with 1 update (#8249)
  core: bump ruff from 0.1.13 to 0.1.14 (#8247)
  website: bump react-tooltip from 5.25.2 to 5.26.0 in /website (#8248)
  Update applications.md
  website/docs: fix nginx ingress proxy example (#8245)
  website/blog: add Rebecca's byline, add links for Reddit screenshots (#8238)
  website/blog: Security hygiene Blog (#8225)
  translate: Updates for file locale/en/LC_MESSAGES/django.po in zh_CN (#8235)
  translate: Updates for file web/xliff/en.xlf in zh-Hans (#8232)
  web: bump the storybook group in /web with 7 updates (#8231)
  core: bump drf-spectacular from 0.27.0 to 0.27.1 (#8230)
  translate: Updates for file web/xliff/en.xlf in zh_CN (#8233)
  translate: Updates for file locale/en/LC_MESSAGES/django.po in zh-Hans (#8234)
  web/components: improve error handling in ak-search-select (#8228)
  rbac: fix invitations listing with restricted permissions (#8227)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant