Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

root: fix system check warnings #8277

Merged
merged 1 commit into from Jan 24, 2024
Merged

root: fix system check warnings #8277

merged 1 commit into from Jan 24, 2024

Conversation

BeryJu
Copy link
Member

@BeryJu BeryJu commented Jan 23, 2024

Details

  • Move django check command to migrate script so we can use the config loader to set --deploy correctly based on debug setting
  • Disable some warnings which are caused by us using custom session and csrf middleware subclasses
  • Disable some warnings which are handled by the reverse proxy (either external or go) (HSTS, https redirect)

Checklist

  • Local tests pass (ak test authentik/)
  • The code has been formatted (make lint-fix)

If an API change has been made

  • The API schema has been updated (make gen-build)

If changes to the frontend have been made

  • The code has been formatted (make web)
  • The translation files have been updated (make i18n-extract)

If applicable

  • The documentation has been updated
  • The documentation has been formatted (make website)

@BeryJu BeryJu requested a review from rissson January 23, 2024 19:47
@BeryJu BeryJu requested review from a team as code owners January 23, 2024 19:47
Copy link

netlify bot commented Jan 23, 2024

Deploy Preview for authentik-storybook ready!

Name Link
🔨 Latest commit 473719b
🔍 Latest deploy log https://app.netlify.com/sites/authentik-storybook/deploys/65b0ed68b29af60008294835
😎 Deploy Preview https://deploy-preview-8277--authentik-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jan 23, 2024

Deploy Preview for authentik ready!

Name Link
🔨 Latest commit 7b4821a
🔍 Latest deploy log https://app.netlify.com/sites/authentik/deploys/65b01d4c05d2ac000855b421
😎 Deploy Preview https://deploy-preview-8277--authentik.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Jan 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a62cca3) 92.32% compared to head (473719b) 51.59%.
Report is 9 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #8277       +/-   ##
===========================================
- Coverage   92.32%   51.59%   -40.73%     
===========================================
  Files         625      626        +1     
  Lines       30832    30917       +85     
===========================================
- Hits        28465    15951    -12514     
- Misses       2367    14966    +12599     
Flag Coverage Δ
e2e 50.01% <100.00%> (-0.54%) ⬇️
integration 26.16% <100.00%> (-0.07%) ⬇️
unit ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

authentik PR Installation instructions

Instructions for docker-compose

Add the following block to your .env file:

AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-root-fix-warnings-1706040656-9d1dbe4
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s

For arm64, use these values:

AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-root-fix-warnings-1706040656-9d1dbe4-arm64
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s

Afterwards, run the upgrade commands from the latest release notes.

Instructions for Kubernetes

Add the following block to your values.yml file:

authentik:
    outposts:
        container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
image:
    repository: ghcr.io/goauthentik/dev-server
    tag: gh-root-fix-warnings-1706040656-9d1dbe4

For arm64, use these values:

authentik:
    outposts:
        container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
image:
    repository: ghcr.io/goauthentik/dev-server
    tag: gh-root-fix-warnings-1706040656-9d1dbe4-arm64

Afterwards, run the upgrade commands from the latest release notes.

Signed-off-by: Jens Langhammer <jens@goauthentik.io>
@rissson rissson enabled auto-merge (rebase) January 24, 2024 10:59
@BeryJu BeryJu disabled auto-merge January 24, 2024 11:10
@BeryJu BeryJu merged commit 9ed2b74 into main Jan 24, 2024
63 of 65 checks passed
@BeryJu BeryJu deleted the root/fix-warnings branch January 24, 2024 11:10
kensternberg-authentik added a commit that referenced this pull request Jan 25, 2024
* main: (109 commits)
  translate: Updates for file web/xliff/en.xlf in fr (#8296)
  translate: Updates for file locale/en/LC_MESSAGES/django.po in fr (#8295)
  website: update wording (#8290)
  enterrpise: exclude inactive users from license (#8294)
  web: bump API Client version (#8292)
  core: compile backend translations (#8291)
  events: migrate SystemTasks to DB (#8159)
  web/admin: fix footer links not being parsed on settings page (#8289)
  root: fix system check warnings (#8277)
  web: bump API Client version (#8288)
  enterprise: add full audit log [AUTH-458] (#8177)
  web: bump the esbuild group in /web with 2 updates (#8282)
  web: bump the sentry group in /web with 1 update (#8281)
  web: bump @codemirror/lang-html from 6.4.7 to 6.4.8 in /web (#8283)
  core: bump bandit from 1.7.6 to 1.7.7 (#8285)
  core: bump selenium from 4.16.0 to 4.17.2 (#8284)
  core: bump github.com/go-openapi/runtime from 0.26.2 to 0.27.0 (#8287)
  core: bump github.com/google/uuid from 1.5.0 to 1.6.0 (#8286)
  website/docs: Improve example nginx reverse proxy config (#8160)
  translate: Updates for file web/xliff/en.xlf in zh_CN (#8274)
  ...
kensternberg-authentik added a commit that referenced this pull request Jan 25, 2024
* main: (76 commits)
  core: compile backend translations (#8311)
  translate: Updates for file web/xliff/en.xlf in zh-Hans (#8304)
  translate: Updates for file web/xliff/en.xlf in zh_CN (#8305)
  translate: Updates for file locale/en/LC_MESSAGES/django.po in zh_CN (#8300)
  translate: Updates for file locale/en/LC_MESSAGES/django.po in zh-Hans (#8301)
  events: fix missing labels on prometheus metrics (#8309)
  core: bump goauthentik.io/api/v3 from 3.2023106.4 to 3.2023106.5 (#8302)
  web: bump the wdio group in /tests/wdio with 4 updates (#8303)
  web: restore test anchor tag (#8298)
  translate: Updates for file web/xliff/en.xlf in fr (#8296)
  translate: Updates for file locale/en/LC_MESSAGES/django.po in fr (#8295)
  website: update wording (#8290)
  enterrpise: exclude inactive users from license (#8294)
  web: bump API Client version (#8292)
  core: compile backend translations (#8291)
  events: migrate SystemTasks to DB (#8159)
  web/admin: fix footer links not being parsed on settings page (#8289)
  root: fix system check warnings (#8277)
  web: bump API Client version (#8288)
  enterprise: add full audit log [AUTH-458] (#8177)
  ...
kensternberg-authentik added a commit that referenced this pull request Jan 25, 2024
* main: (131 commits)
  web: provide a context for checking the status of the enterprise license (#8153)
  core: compile backend translations (#8311)
  translate: Updates for file web/xliff/en.xlf in zh-Hans (#8304)
  translate: Updates for file web/xliff/en.xlf in zh_CN (#8305)
  translate: Updates for file locale/en/LC_MESSAGES/django.po in zh_CN (#8300)
  translate: Updates for file locale/en/LC_MESSAGES/django.po in zh-Hans (#8301)
  events: fix missing labels on prometheus metrics (#8309)
  core: bump goauthentik.io/api/v3 from 3.2023106.4 to 3.2023106.5 (#8302)
  web: bump the wdio group in /tests/wdio with 4 updates (#8303)
  web: restore test anchor tag (#8298)
  translate: Updates for file web/xliff/en.xlf in fr (#8296)
  translate: Updates for file locale/en/LC_MESSAGES/django.po in fr (#8295)
  website: update wording (#8290)
  enterrpise: exclude inactive users from license (#8294)
  web: bump API Client version (#8292)
  core: compile backend translations (#8291)
  events: migrate SystemTasks to DB (#8159)
  web/admin: fix footer links not being parsed on settings page (#8289)
  root: fix system check warnings (#8277)
  web: bump API Client version (#8288)
  ...
kensternberg-authentik added a commit that referenced this pull request Jan 25, 2024
* main: (119 commits)
  web: provide a context for checking the status of the enterprise license (#8153)
  core: compile backend translations (#8311)
  translate: Updates for file web/xliff/en.xlf in zh-Hans (#8304)
  translate: Updates for file web/xliff/en.xlf in zh_CN (#8305)
  translate: Updates for file locale/en/LC_MESSAGES/django.po in zh_CN (#8300)
  translate: Updates for file locale/en/LC_MESSAGES/django.po in zh-Hans (#8301)
  events: fix missing labels on prometheus metrics (#8309)
  core: bump goauthentik.io/api/v3 from 3.2023106.4 to 3.2023106.5 (#8302)
  web: bump the wdio group in /tests/wdio with 4 updates (#8303)
  web: restore test anchor tag (#8298)
  translate: Updates for file web/xliff/en.xlf in fr (#8296)
  translate: Updates for file locale/en/LC_MESSAGES/django.po in fr (#8295)
  website: update wording (#8290)
  enterrpise: exclude inactive users from license (#8294)
  web: bump API Client version (#8292)
  core: compile backend translations (#8291)
  events: migrate SystemTasks to DB (#8159)
  web/admin: fix footer links not being parsed on settings page (#8289)
  root: fix system check warnings (#8277)
  web: bump API Client version (#8288)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants