Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Server and worker are using same labels and wrong selector on Service #7

Closed
cubic3d opened this issue May 8, 2021 · 0 comments
Closed

Comments

@cubic3d
Copy link
Contributor

cubic3d commented May 8, 2021

Currently on 1.0.0-RC5 the server and worker deployment are templated by a single template resulting in same labels:

apiVersion: apps/v1
kind: Deployment
metadata:
  name: RELEASE-NAME-authentik-worker
  labels:
    helm.sh/chart: authentik-1.0.0-RC5
    app.kubernetes.io/name: authentik
    app.kubernetes.io/instance: RELEASE-NAME
    app.kubernetes.io/version: "2021.4.5"
    app.kubernetes.io/managed-by: Helm
...
apiVersion: apps/v1
kind: Deployment
metadata:
  name: RELEASE-NAME-authentik-server
  labels:
    helm.sh/chart: authentik-1.0.0-RC5
    app.kubernetes.io/name: authentik
    app.kubernetes.io/instance: RELEASE-NAME
    app.kubernetes.io/version: "2021.4.5"
    app.kubernetes.io/managed-by: Helm

which makes impossible for the Service to select the server (it matches both):

apiVersion: v1
kind: Service
...
  labels:
    helm.sh/chart: authentik-1.0.0-RC5
    app.kubernetes.io/name: authentik
    app.kubernetes.io/instance: RELEASE-NAME
    app.kubernetes.io/version: "2021.4.5"
    app.kubernetes.io/managed-by: Helm

Services should also not select by Helm related labels, see https://github.com/k8s-at-home/library-charts/blob/main/charts/stable/common/templates/lib/chart/_labels.tpl#L16

@BeryJu BeryJu mentioned this issue May 20, 2021
Merged
@BeryJu BeryJu closed this as completed in f1a6563 May 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant