Fix sourcemap comments to be used on file transformers with CSS output #116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IvanSanchez
force-pushed
the
css-sourcemap-comments
branch
2 times, most recently
from
085d52b
to
4d52298
Compare
|
@Rich-Harris I'll leave the |
IvanSanchez
force-pushed
the
css-sourcemap-comments
branch
from
4d52298
to
0f92e02
Compare
| @@ -1,7 +1,7 @@ | |||
| { | |||
| "name": "gobble", | |||
| "description": "The last build tool you'll ever need", | |||
| "version": "0.11.3", | |||
| "version": "0.11.4", | |||
There was a problem hiding this comment.
Can you revert this change and squash commits?
IvanSanchez
force-pushed
the
css-sourcemap-comments
branch
from
0f92e02
to
0234bfd
Compare
|
@TrySound This has been rebased against |
|
Cool, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a case where a file transformer (namely,
gobble-sass-all) takes.sassfiles as input and.cssfiles as output - the code was (wrongly) assuming that the input file extension decides which sourcemap comment style to use. In other words: my CSS files were being written a javascript-style sourcemap comment.