Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cloudrun] - custom audiences are being cleared on goblet deploys #421

Open
quajones opened this issue Aug 25, 2023 · 3 comments
Open

[cloudrun] - custom audiences are being cleared on goblet deploys #421

quajones opened this issue Aug 25, 2023 · 3 comments
Labels
enhancement Improvement to existing feature or Goblet in general

Comments

@quajones
Copy link
Contributor

custom audiences: https://cloud.google.com/run/docs/configuring/custom-audiences#setting

Setting custom audiences for Cloud Run is at the service level and applies to all serving revisions, similar to IAM authorization membership.

after setting custom audiences and describing the service you are able to see the proper annotation for the custom audiences being set
gcloud beta run services update service --add-custom-audiences=https://audience.com
gcloud run services describe service --format export

apiVersion: serving.knative.dev/v1
kind: Service
metadata:
  annotations:
    run.googleapis.com/custom-audiences: '["https://audience.com”]’

once a cloud run service is redeployed this is no longer set and needs to be explicitly called out in the config.json cloudrun configurations

"cloudrun": {
    "launchStage": "BETA",
    "customAudiences": [ "https://audience.com" ]
}

as a potential solution determine if there are any custom audiences already defined for the service before deploy and pass them into the revision

@quajones quajones changed the title [cloudrun] - custom audiences are being reset on goblet deploys [cloudrun] - custom audiences are being cleared on goblet deploys Aug 25, 2023
@anovis
Copy link
Collaborator

anovis commented Aug 25, 2023

would we need to switch the launch stage to beta as well if a custom audience is previously set?

@anovis anovis added the enhancement Improvement to existing feature or Goblet in general label Aug 25, 2023
@quajones
Copy link
Contributor Author

@anovis yes the custom audiences are not generally available just yet

@anovis
Copy link
Collaborator

anovis commented Apr 8, 2024

@quajones custom audiences are now GA as of November

https://cloud.google.com/run/docs/configuring/custom-audiences

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improvement to existing feature or Goblet in general
Projects
None yet
Development

No branches or pull requests

2 participants