Fix popover with very narrow text. #1894
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goblindegook#1702 If the page is resized before any footnotes have been opened, the `resize` action can compute a very small `max-width` based on zero size footnote contents. This was allowed to happen because `isMounted` always returns true after the popover element is created but not yet shown. - `isMounted` now checks whether the popover is contained in the DOM. - `createElementFromHTML` now unwraps newly created elements to improve robustness in case `parentElement` gets used elsewhere.
|
Thanks for this, would you be able to cover the change with a test? (Probably using Cypress since resizing the browser is one of the steps to reproduce.) |
|
Here is the test which fails when the fix is undone:
|
goblindegook
approved these changes
May 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1702
If the page is resized before any footnotes have been opened, the
resizeaction can compute a very smallmax-widthbased on zero size footnote contents. This was allowed to happen becauseisMountedalways returns true after the popover element is created but not yet shown.isMountednow checks whether the popover is contained in the DOM.createElementFromHTMLnow unwraps newly created elements to improve robustness in caseparentElementgets used elsewhere.