You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Feb 24, 2024. It is now read-only.
I think i've found an issue with the Dockerfile and buffalo's travis configuration, while we're apparently running our tests on go 1.7 and latest, it seems that given we're running our tests by building our Dockerfile we're actually using the latest stable rather than the versions travis sets outside the docker image.
I changed our Dockerfile to print the Go version thats running when we execute go build . and as you can see in the following 2 log files
@markbates sure, i would like to. just to confirm, would you like to continue running our tests with docker build or do you think we should try running these inside travis directly ?.
i'm thinking on how to determine the docker image to base ours (by setting the ENV) and doesn't seem easy given go version output wont match Go docker images tags.
Any reason why not to run these on travis ? (outside docker).
The big reason why i was using docker, was because a) it was easier to get set up than Travis b) i could run the docker file locally when trying to smoke test and figure out why it was failing on Travis.
oh, thats a good reason, one thing i didn't know is we can define env variables per (Go in our case) version inside travis, i'll keep you posted on how it goes, thanks for the explanation @markbates.
I think i've found an issue with the Dockerfile and buffalo's travis configuration, while we're apparently running our tests on go 1.7 and latest, it seems that given we're running our tests by building our Dockerfile we're actually using the latest stable rather than the versions travis sets outside the docker image.
I changed our Dockerfile to print the Go version thats running when we execute
go build .
and as you can see in the following 2 log fileshttps://travis-ci.org/gobuffalo/buffalo/jobs/191527609#L1641
https://travis-ci.org/gobuffalo/buffalo/jobs/191527608#L1635
its the same version of Go, this seems to be related to the fact that our Dockerfile is built
FROM golang
.The text was updated successfully, but these errors were encountered: