Skip to content
This repository has been archived by the owner on Jun 25, 2022. It is now read-only.

Box.decompress opens gzip.Reader without closing #154

Closed
zeripath opened this issue Feb 5, 2019 · 0 comments · Fixed by #197
Closed

Box.decompress opens gzip.Reader without closing #154

zeripath opened this issue Feb 5, 2019 · 0 comments · Fixed by #197
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@zeripath
Copy link

zeripath commented Feb 5, 2019

packr/box.go

Line 127 in b0dc8ae

reader, err := gzip.NewReader(bytes.NewReader(bb))

The above line opens a gzip.Reader which is never closed leaking a file descriptor.

This will likely leak a file descriptor.
@markbates markbates added bug Something isn't working good first issue Good for newcomers labels Feb 6, 2019
@williamhgough williamhgough mentioned this issue May 5, 2019
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Issue-154: unclosed gzip.Reader williamhgough/packr
2 participants
@markbates @zeripath