Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flat/Eager creation need some work #304

Open
1 of 2 tasks
mclark4386 opened this issue Nov 14, 2018 · 0 comments
Open
1 of 2 tasks

Flat/Eager creation need some work #304

mclark4386 opened this issue Nov 14, 2018 · 0 comments
Assignees
@mclark4386
Labels
f: associations the associations feature in pop proposal A suggestion for a change, feature, enhancement, etc s: accepted This proposal was accepted. Someone can start working on it.
Milestone
v6.z.0 - associat...

Comments

@mclark4386
Copy link
Member

mclark4386 commented Nov 14, 2018 •
edited

  • Eager and Flat Create should be refactored into one function.
  • After checking if nested model ids are zero we should also check if that model exists
@mclark4386 mclark4386 self-assigned this Nov 14, 2018
@mclark4386 mclark4386 mentioned this issue Nov 20, 2018
Merged
@stanislas-m stanislas-m added proposal A suggestion for a change, feature, enhancement, etc s: accepted This proposal was accepted. Someone can start working on it. labels Nov 30, 2018
@sio4 sio4 added the f: associations the associations feature in pop label Sep 20, 2022
@sio4 sio4 added this to the v6.1.0 - association improvement milestone Sep 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mclark4386 mclark4386

Labels
f: associations the associations feature in pop proposal A suggestion for a change, feature, enhancement, etc s: accepted This proposal was accepted. Someone can start working on it.
Projects
None yet
Milestone
v6.z.0 - association improvement
Development

No branches or pull requests
3 participants
@sio4 @mclark4386 @stanislas-m