"Create" does not pass Context properly

[martinei]

I use the context Propagation to get (Jaeger-) Traced for the database calls. This works mostly, but Create executes a named statement that produces "dangling" spans due to a missing context. I observered this with postgres and pop 5.3.4 but looking at the code I think the problem still exists and extends to other dialects as well.

The "Exec" here:

pop/dialect_common.go

Line 88 in e572a4d

_, err = stmt.Exec(model.Value)

should actually be an "ExecContext". Please note, that the preparation of the Named Query already receives the correct Context (via

pop/store.go

Line 48 in e572a4d

func (s contextStore) NamedExec(query string, arg interface{}) (sql.Result, error) {

), but that does not cover the actual execution.

[aeneasr]

If you could supply a PR we can merge that rihgt away :)

[martinei]

@aeneasr Could you have a look?