Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gobwas/pool dependency issue #49

Closed
zdebra opened this issue May 25, 2018 · 2 comments
Closed

gobwas/pool dependency issue #49

zdebra opened this issue May 25, 2018 · 2 comments
Labels
bug

Comments

@zdebra
Copy link

zdebra commented May 25, 2018 •
edited
Loading

Right now, dep will resolve gobwas/pool dependency in a way that latest (and used) version is e294a5482d9a8523f8e6b2744ea2185083c838af which is currently 2 commits back. The reason is because it is last tagged version.

Current version of gobwas/ws with older version of gobwas/pool wont compile because of breaking change.

The best solution is to just add tag to latest commit in gobwas/pool.
@gobwas
Copy link
Owner

gobwas commented May 25, 2018

Hi @zdebra!
Thank you for the issue. I will tag it during closest few hours. 🚀

@gobwas gobwas added the bug label May 25, 2018
@gobwas
Copy link
Owner

gobwas commented May 25, 2018

@zdebra could you try it? It must work now.

@gobwas gobwas closed this as completed May 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gobwas @zdebra