Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Class imports aren't strictly correct #170

Open
mewejo opened this issue Jun 28, 2023 · 0 comments · May be fixed by #171 or #187
Open

Class imports aren't strictly correct #170

mewejo opened this issue Jun 28, 2023 · 0 comments · May be fixed by #171 or #187

Comments

@mewejo
Copy link

mewejo commented Jun 28, 2023

Hi,

I've been using the SDK today and it's been great, thank you.

However upon opening a PR and running PHPStan on the code, it's throwing the following error:

 ------ --------------------------------------------------------------------------------- 
  Line   Http/Controllers/GoCardlessWebhookController.php                                 
 ------ --------------------------------------------------------------------------------- 
  28     Parameter #2 $event of method                                                    
         Grizzlyware\Cub\Invoicing\PaymentGatewayDrivers\GoCardlessDriver::handleEvent()  
         expects GoCardlessPro\Resources\Event,                                           
         GoCardlessPro\GoCardlessPro\Resources\Event given.                               
 ------ --------------------------------------------------------------------------------- 

* @return GoCardlessPro\Resources\Event[] the events included in the

I expect the same issue is true for the exception below it too. While IDEs can work around it, PHPStan is rightly complaining about it.

@mewejo mewejo linked a pull request Jun 29, 2023 that will close this issue
@VincentLanglet VincentLanglet linked a pull request May 7, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant