-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gemspec: Move development deps to Gemfile #248
Gemspec: Move development deps to Gemfile #248
Conversation
What's the benefit of this? |
After this, we can make more Gemfiles, to be able to run them next to each other, in the test platform matrix in Travis. "You get an old ActiveSupport, you get a newer one." All chosen via Gemfile versions, all appropriate to the versions we are testing. |
In travis.yml, we can include an env variable And then, get rid of the weird (Update: This turned out to be almost right. Below, we mention the |
I could push on, in that direction, in this PR, to see if the changes bear out the promise. Or, we could try taking it a step at a time. |
Please take your idea as far as you feel necessary. |
@michaelklishin Here's what the overview looks like when using the |
@jensnockert Does this work around #244? |
df5d7d2
to
a11f540
Compare
(Squashed to 1 commit: most learning Travis is best kept out of the long-term commit log.) |
This no longer merges cleanly. |
@olleolleolle thank you, I like this solution. |
a11f540
to
ea5c746
Compare
ea5c746
to
950cab8
Compare
@michaelklishin Rebased. Thanks for the encouragement. |
This PR moves the development dependencies out of the gemspec and into groups in the Gemfile.
It also moves the version-dependent activesupport dependency into separated Gemfiles, so that the Travis build matrix targets can choose which activesupport version is for them.
By trying to leverage Bundler's
platform
support, we can get away from weird hacks in the gemspec.In the Travis build matrix each Ruby version gets its dependencies pointed out to it using the
gemfile:
travis.yml feature. Agemfiles/
folder is supplied.