Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GO_DEPENDENCY_LABEL_${pipeline name} environment variable description is incorrect #255

Closed
jseparovic opened this issue Mar 8, 2019 · 1 comment

Comments

@jseparovic
Copy link

It's not clear in the docs that the GO_DEPENDENCY_LABEL_ suffix should be the upstream pipeline's "Material Name". This name should be converted to uppercase with hyphens converted to underscores.

Eg:
The Pipeline Label for an Upstream Pipeline with "Material Name" = "upstream_services-frontend"

Would be available as the environment variable:
${GO_DEPENDENCY_LABEL_UPSTREAM_SERVICES_FRONTEND}

@ankitsri11
Copy link
Contributor

@jseparovic thank you for pointing it out. I've raised a PR: #261 for an update.

Closing this issue out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants