Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sample authentication plugin is broken in latest 15.3 #28

Closed
pshelton-skype opened this issue Oct 2, 2015 · 4 comments
Closed

Sample authentication plugin is broken in latest 15.3 #28

pshelton-skype opened this issue Oct 2, 2015 · 4 comments

Comments

@pshelton-skype
Copy link

The sample authentication plugin works as intended when run against the 15.2.0 tag in the gocd repository, but updating to the latest commit to master (pre-release 15.3) causes a 404 to occur anytime the plugin icon is clicked, breaking the authentication flow, as demonstrated below.

15.2:

15 2

15.3:

15 3

The developer documentation hasn't been updated to indicate what change is required to the authentication plugins to make them work in 15.3 and there are no bugs related to the authentication flow on the main gocd project, but I can't determine whether this is API breaking change, a bug in Go, or a bug in the plugin.

@pshelton-skype
Copy link
Author

Possibly related to gocd/gocd@764eb28?

@zabil
Copy link
Contributor

zabil commented Oct 5, 2015

@pshelton-skype that's the fix to this problem. Can you tell us which revision of gocd/gocd you are at?

@zabil
Copy link
Contributor

zabil commented Oct 5, 2015

I've verified that it works on gocd/master revision ad8fc27d552f038fc8609c27cd0d6e4eadd90739

@pshelton-skype
Copy link
Author

Oh, weird. I managed to clone the main gocd repository from Aug 19 rather than latest somehow. Thanks for the verification.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants