Improve docker image logging #11296
Merged
Improve docker image logging #11296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
chadlwilson
commented
Feb 11, 2023
chadlwilson
commented
- Avoids cut-off logging lines to console with wrapper in docker images
- Slight reduction to CentOS image size by removing weak dependencies
The current configuration is buffered, which means you get half-logged lines which are extremely confusing, and not really the norm these days. Don't expect any major performance impact from this, as the content logged is just not that huge, and in most cases not piped to the wrapper on the console.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.