Tell dockerd to only bind TCP/HTTP API to localhost #11406
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- resolves the 15s delay caused by listening on 0.0.0.0 without TLS - listens on localhost only which is not perfect, but more secure - allows user opt-out of all TCP listens, as well as opt-in to more secure config via DOCKERD_ADDITIONAL_ARGS - continues listening on localhost due to possibility some tools/libs can only talk to Docker on TCP, not unix sockets by default to minimise chance of breaking change - waits DOCKERD_MAX_WAIT_SECS (default 30) for the daemon to start (blocking agent startup), exiting if it doesn't, to avoid hidden issues like we had here - image sanity tests will fail if the daemon takes 15s to start, as long as we wait for it
This was referenced Mar 18, 2023
chadlwilson
added
bug-fix
security
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11378
DOCKERD_ADDITIONAL_ARGSDOCKERD_MAX_WAIT_SECS(default 30) for the daemon to start (blocking agent startup), exiting if it doesn't, to avoid hidden issues like we had here