Clean up more legacy Prototype and related vanilla JS #11449
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is technically required by the Prototype.JS-based Modalbox however only when transitions are enabled. We don't enable that and it seems to work fine without it, so let's remove some confusing JS that seems unnecessary.
This seemed to only have affect on some ancient Rails pages long since removed. Only the stage details overview job breakdown uses css_toggling right now and the element aligner seems to not do anything.
Last usage seemed to disappear this legacy sidebar removal earlier in 7662c6d
chadlwilson
added
technical-debt
javascript
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes a bunch of seemingly unnecessary legacy Javascript lingering around