Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve pipeline config tab switch confirmation dialog message #11535

Merged

Conversation

JeroenOortwijn
Copy link
Contributor

@JeroenOortwijn JeroenOortwijn commented May 4, 2023

There is no Proceed button, only a Yes and No button.

Rewrote it to be similar to the message in pipeline_template_widget.tsx.

@chadlwilson chadlwilson added this to the Release 23.2.0 milestone May 4, 2023
@chadlwilson chadlwilson changed the title Improve confirmation dialog message Improve pipeline config tab switch confirmation dialog message May 4, 2023
@chadlwilson
Copy link
Member

Thanks!

@chadlwilson chadlwilson merged commit 23dd4c3 into gocd:master May 4, 2023
0 of 2 checks passed
@chadlwilson
Copy link
Member

chadlwilson commented May 5, 2023

It's a small change but if you want to see it in action on latest code you can try with experimental builds (23.2.0-16417+) at https://www.gocd.org/download/

image

@JeroenOortwijn
Copy link
Contributor Author

Thanks, but no need. I believe the screenshot. 😉

I wasn't sure if I needed to put a manual newline between the two sentences, but I see that it automatically puts the second sentence on a new line, nice!

@JeroenOortwijn JeroenOortwijn deleted the Improve_confirmation_dialog_message branch May 5, 2023 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants