Reduce CSS size of bundles #11625
Merged
Reduce CSS size of bundles #11625
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hacky excludes is messy, better to opt in by duplicating the `@ExtendsWith` from the super-class
Makes it difficult to diff wars/zips with official ones
chadlwilson
force-pushed
the
slimmer-fonts
branch
2 times, most recently
from
61416b8
to
001d1dd
Compare
Apparently it's a lot better to use direct imports; it's also more explicit which is easier to debug. https://guides.rubyonrails.org/asset_pipeline.html#manifest-files-and-directives https://www.vector-logic.com/blog/posts/sprockets-require-directives-and-css-at-import-rules
This is causing huge bloating of all sprockets asset pipelined CSS, because font-awesome-glyphs (which should really go away) is being included in many places. Since this was also duplicating an inclusion of font-awesome and bourbon the CSS bloats massively especially with the much larger number of icons in Font Awesome 6. We should rely on these imports having been done elsewhere if the user wants to use font-awesome, this file is just some mix-ins to make glyphs easier to use.
chadlwilson
force-pushed
the
slimmer-fonts
branch
from
001d1dd
to
75ce930
Compare
No need to include tabs; these are just links anyway - so can simplify this all. Also corrects somewhat the display for the group admin editing view which uses weird colours/buttons.
Clearfix mixin seems unnecessary, there is one from bourbon being used as well
chadlwilson
force-pushed
the
slimmer-fonts
branch
from
b496879
to
0f755ac
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up to #11006 which made obvious the massive duplication we have in Sprockets/Rails-bundled css assets across SPAs, the main
application.cssand so-forth. This seems to be due to duplication imports of font-awesome CSS.This PR