Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix font display consistency across views #11652

Merged
merged 4 commits into from Jun 8, 2023

Conversation

chadlwilson
Copy link
Member

Fix some minor UI/UX font bugs that are a bit irritating

  • Fix Open Sans display on legacy views (Stage Details, Job/Build Details, VSM etc)
  • Fix consistency of font smoothing (especially for headers) on MacOS/Firefox
  • Fix display of build console logs on IOS Safari by making a decent font selectable (Menlo)
  • Remove some minor CSS cruft on the way

Bit of a nitpick but Consolas and Monaco aren't available on IOS Safari. Menlo is closed to Monaco.
Currently Open Sans isn't rendering properly on some views causing inconsistency, especially in headers bars.
Foundation Sites and other places seem to be applying font smoothing. Currently there is irritating inconsistency across views. Where
Foundation for Sites is loading font both font smoothing vars are loaded, but there are other places it's not being used. Setting these
manually seems to at least make things consistent on Firefox MacOS.

If we ever get rid of Foundation for Sites this will need to be tidied up further :-(
@chadlwilson chadlwilson added this to the Release 23.2.0 milestone Jun 8, 2023
@chadlwilson chadlwilson merged commit 0607033 into gocd:master Jun 8, 2023
1 of 2 checks passed
@chadlwilson chadlwilson deleted the fix-font-consistency branch June 8, 2023 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant