Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve SCM Auto Update UX #11663

Merged
merged 3 commits into from Jun 11, 2023
Merged

Conversation

chadlwilson
Copy link
Member

@chadlwilson chadlwilson commented Jun 11, 2023

Correct some minor issues when managing SCMs and autoUpdate

  • disabled radio buttons correctly when viewing config repo materials in pipeline config SPA
  • displays the value of "Auto Update" for Pluggable SCMs in pipeline config SPA along with other SCM config
  • displays the value of "Auto Update" for Pluggable SCMs in the Pluggable SCM admin summary

Relates to #11636 and #11664

…rial is readOnly

Confusingly there seems to be a concept of both disabled and readonly for material fields, and not sure
how they are respectively used. Rather than rationalise all this, identify that when defined in a config
repo it is "readonly" that seems to be true, and all inputs except for the material AutoUpdate toggle
are already correctly disabled. This corrects the toggle.
@chadlwilson chadlwilson added this to the Release 23.2.0 milestone Jun 11, 2023
@chadlwilson chadlwilson merged commit 28f8214 into gocd:master Jun 11, 2023
1 check passed
@chadlwilson chadlwilson deleted the improve-auto-update-ux branch June 11, 2023 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant