Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stage History pagination links broken on 23.2.0 #11790

Closed
chadlwilson opened this issue Jul 24, 2023 · 0 comments · Fixed by #11791
Closed

Stage History pagination links broken on 23.2.0 #11790

chadlwilson opened this issue Jul 24, 2023 · 0 comments · Fixed by #11791
Labels
bug stage-overview ui / ux
Milestone
Release 23.3.0

Comments

@chadlwilson
Copy link
Member

chadlwilson commented Jul 24, 2023 •
edited

Issue Type
  • Bug Report
Summary

On GoCD 23.2.0 clicking the pagination links at the bottom of the Stage History banner are broken:

image

Steps to Reproduce
  1. Navigate to stage details for a pipeline with more than 10 builds of a given stage
  2. Click any of the pagination links
Expected Results

Should navigate to the same stage details, but with changes to viewed stage history

Actual Results

You will see a big ugly 404 temporarily, and it won't actually change the history:

image

Possible Fix

The problem is with this change: d51e65c#diff-596f318bfda7e8664d68e3b5722350a2e6b3540d5caaabe6356ced49f1aa4575L1065-L1066

The history/* route is no longer going to Rails and so not being handled correctly. And apparently no unit or integration tests to validate Stage History handling :-(
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug stage-overview ui / ux
Projects
None yet
Milestone
Release 23.3.0
Development

Successfully merging a pull request may close this issue.

Fix stage history pagination handling chadlwilson/gocd
1 participant
@chadlwilson