Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make template selector dropdowns alphabetically sorted #12212

Merged
merged 3 commits into from Dec 24, 2023

Conversation

jales-els
Copy link
Contributor

@jales-els jales-els commented Nov 3, 2023

When you have a long list of templates it's hard to find the one you need. Having the list sorted alphabetically helps with this

image

image

@chadlwilson
Copy link
Member

Thanks for this. I'm sympathetic to this change.

Currently I believe the order is deterministic but unhelpful, just that it's probably 'configuration definition order' in the underlying config file. Which roughly speaking is usually order or creation (similar to pipeline groups), but I'm not even sure that's 100% true in all cases 😅

We've need to double check that this doesn't have unintended consequences when editing/deleting/adding/cloning templates (probably shouldn't) and add some kind of unit test or assertion.

@chadlwilson
Copy link
Member

I assume it was intentional at this stage that you have only attempted to sort the dropdown selector rather than the admin > templates list in the second screenshot?

Although I do note that this list's order seems kind of random right now, it's not even the creation order of the templates it seems - so would consider a PR for that too, as long as it seems broadly consistent with behaviour elsewhere.

@chadlwilson chadlwilson merged commit 11a8fae into gocd:master Dec 24, 2023
1 of 2 checks passed
@chadlwilson chadlwilson removed their assignment Dec 24, 2023
@chadlwilson chadlwilson changed the title fix: templates in alphabetical order Make template selector dropdowns alphabetically sorted Dec 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants